Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PROCESSING_TIMEOUT upload error code #3522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add PROCESSING_TIMEOUT upload error code #3522

wants to merge 1 commit into from

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Nov 20, 2024

a significant number of "unknown errors" that we report to users are timing out during processing. this PR creates an error code for it, and we can later choose to display different text in gazebo for that error code

note: worker will attempt to set this error code and save everything when it gets the "soft timeout" signal. but there is no guarantee it won't be forcibly killed before it can save everything. there will still be some unknown uploads from that

sibling PR in shared: codecov/shared#431

@matt-codecov matt-codecov requested a review from a team November 20, 2024 22:06
@codecov-staging
Copy link

codecov-staging bot commented Nov 20, 2024

Bundle Report

Changes will decrease total bundle size by 223 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.61MB 147 bytes (-0.0%) ⬇️
gazebo-staging-system 5.56MB 76 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 20, 2024

Bundle Report

Changes will decrease total bundle size by 223 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.56MB 76 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.61MB 147 bytes (-0.0%) ⬇️

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      806           
  Lines       14376    14376           
  Branches     4079     4086    +7     
=======================================
  Hits        14222    14222           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...8be746f. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (21fe01f) to head (8be746f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      806           
  Lines       14376    14376           
  Branches     4079     4079           
=======================================
  Hits        14222    14222           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...8be746f. Read the comment docs.


🚨 Try these New Features:

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (21fe01f) to head (8be746f).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3522   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      806           
  Lines       14376    14376           
  Branches     4079     4086    +7     
=======================================
  Hits        14222    14222           
  Misses        147      147           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/utils/commit.ts 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...8be746f. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
8be746f Wed, 20 Nov 2024 22:11:09 GMT Cloud Enterprise

@matt-codecov matt-codecov changed the base branch from main to staging November 20, 2024 22:38
@matt-codecov matt-codecov changed the base branch from staging to main November 20, 2024 22:38
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants