-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PROCESSING_TIMEOUT upload error code #3522
base: main
Are you sure you want to change the base?
Conversation
Bundle ReportChanges will decrease total bundle size by 223 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 223 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3522 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 806 806
Lines 14376 14376
Branches 4079 4086 +7
=======================================
Hits 14222 14222
Misses 147 147
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3522 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 806 806
Lines 14376 14376
Branches 4079 4079
=======================================
Hits 14222 14222
Misses 147 147
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚨 Try these New Features:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3522 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 806 806
Lines 14376 14376
Branches 4079 4086 +7
=======================================
Hits 14222 14222
Misses 147 147
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it
a significant number of "unknown errors" that we report to users are timing out during processing. this PR creates an error code for it, and we can later choose to display different text in gazebo for that error code
note: worker will attempt to set this error code and save everything when it gets the "soft timeout" signal. but there is no guarantee it won't be forcibly killed before it can save everything. there will still be some unknown uploads from that
sibling PR in shared: codecov/shared#431