-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-GH onboard links #3517
Fix non-GH onboard links #3517
Conversation
Bundle ReportChanges will increase total bundle size by 155.32kB (0.9%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 155.32kB (0.9%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3517 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14437 14436 -1
Branches 4101 4100 -1
==========================================
- Hits 14280 14279 -1
Misses 150 150
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3517 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14437 14436 -1
Branches 4094 4093 -1
==========================================
- Hits 14280 14279 -1
Misses 150 150
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3517 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14437 14436 -1
Branches 4101 4100 -1
==========================================
- Hits 14280 14279 -1
Misses 150 150
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with one small tiny tweak requested 🙏
isExternal | ||
hook="codecov-workflow-intro" | ||
> | ||
repo here | ||
javascript config.yml example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: javascript
-> JavaScript
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3517 +/- ##
==========================================
- Coverage 98.91% 98.91% -0.01%
==========================================
Files 806 806
Lines 14437 14436 -1
Branches 4101 4093 -8
==========================================
- Hits 14280 14279 -1
Misses 150 150
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Description
Closes codecov/engineering-team#2540
Figma: https://www.figma.com/design/ZJmSdJUIz03zJdF22kLhAs/GH-2694?node-id=2106-1068&t=CYmX141MuqNWITXE-1
Example
https://preview-pr-3517.codecov.dev/github/codecov/basic-test-results/new/circle-ci