[feat] Add a select all checkbox in the uploads card #3470

rohitvinnakota-codecov · 2024-11-06T19:45:52Z

Design: https://www.figma.com/design/ipt8D8zYKYWOhhlavVT1Ev/GH-1450?node-id=101-3956&node-type=canvas&t=5v7gx62ivRBOKxRt-0

Screen.Recording.2024-11-08.at.11.24.37.AM.mov

Note: This does not currently work with the search filters. There is a tangential follow up in this area here. Will follow up with design to get clarity there before implementing.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-staging · 2024-11-06T19:48:56Z

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	95.55%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
- Coverage   98.92%   98.91%   -0.02%     
==========================================
  Files         806      806              
  Lines       14376    14423      +47     
  Branches     4079     4102      +23     
==========================================
+ Hits        14222    14267      +45     
- Misses        147      149       +2     
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
src/ui/Checkbox/Checkbox.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.72% <95.55%> (-2.28%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.57% <95.91%> (-0.02%)`	⬇️
Services	`99.36% <ø> (ø)`
Shared	`99.33% <ø> (ø)`
UI	`99.21% <100.00%> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...1b2852e. Read the comment docs.

codecov-qa · 2024-11-06T19:48:58Z

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.91%. Comparing base (21fe01f) to head (1b2852e).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	95.55%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
- Coverage   98.92%   98.91%   -0.02%     
==========================================
  Files         806      806              
  Lines       14376    14423      +47     
  Branches     4079     4095      +16     
==========================================
+ Hits        14222    14267      +45     
- Misses        147      149       +2     
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
src/ui/Checkbox/Checkbox.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.72% <95.55%> (-2.28%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.57% <95.91%> (-0.02%)`	⬇️
Services	`99.36% <ø> (ø)`
Shared	`99.33% <ø> (ø)`
UI	`99.21% <100.00%> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...1b2852e. Read the comment docs.

🚨 Try these New Features:

JS Bundle Analysis - Avoid shipping oversized bundles

codecov-public-qa · 2024-11-06T19:48:58Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
3358	2	3356	0

View the top 2 failed tests by shortest run time

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.test.tsx > UploadsCard &gt; select all interactor &gt; shows an intermediate state

Stack Traces | 0.0455s run time

Error: expect(element).toHaveAttribute(&quot;aria-checked&quot;, &quot;mixed&quot;) // element.getAttribute(&quot;aria-checked&quot;) === &quot;mixed&quot;

Expected the element to have attribute:
  aria-checked=&quot;mixed&quot;
Received:
  aria-checked=&quot;true&quot;
 ❯ .../CommitCoverage/UploadsCard/UploadsCard.test.tsx:950:30

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.test.tsx > UploadsCard &gt; select all interactor &gt; sets state to none when clicked on intermediate state

Stack Traces | 0.0462s run time

Error: expect(element).toHaveAttribute(&quot;aria-checked&quot;, &quot;mixed&quot;) // element.getAttribute(&quot;aria-checked&quot;) === &quot;mixed&quot;

Expected the element to have attribute:
  aria-checked=&quot;mixed&quot;
Received:
  aria-checked=&quot;true&quot;
 ❯ .../CommitCoverage/UploadsCard/UploadsCard.test.tsx:964:30

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov · 2024-11-06T19:49:32Z

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.91%. Comparing base (21fe01f) to head (1b2852e).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	95.55%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
- Coverage   98.92%   98.91%   -0.02%     
==========================================
  Files         806      806              
  Lines       14376    14423      +47     
  Branches     4079     4095      +16     
==========================================
+ Hits        14222    14267      +45     
- Misses        147      149       +2     
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
src/ui/Checkbox/Checkbox.tsx	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.72% <95.55%> (-2.28%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.57% <95.91%> (-0.02%)`	⬇️
Services	`99.36% <ø> (ø)`
Shared	`99.33% <ø> (ø)`
UI	`99.21% <100.00%> (+<0.01%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fe01f...1b2852e. Read the comment docs.

…v/gazebo into rvinnakota/add-select-all

codecov-staging · 2024-11-07T15:51:45Z

Bundle Report

Changes will decrease total bundle size by 6.13MB (-35.42%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system	5.57MB	1.47kB (0.03%) ⬆️
gazebo-staging-system-esm	5.62MB	1.67kB (0.03%) ⬆️
gazebo-staging-array-push	(removed)	6.14MB (-100.0%) ⬇️

codecov · 2024-11-07T15:55:37Z

Bundle Report

Changes will decrease total bundle size by 6.13MB (-35.42%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.57MB	1.47kB (0.03%) ⬆️
gazebo-production-system-esm	5.62MB	1.67kB (0.03%) ⬆️
gazebo-production-array-push	(removed)	6.14MB (-100.0%) ⬇️

codecov-releaser · 2024-11-07T15:56:22Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`d316c27`	Thu, 07 Nov 2024 15:56:22 GMT	Expired	Expired
`6eadd77`	Fri, 08 Nov 2024 15:56:57 GMT	Expired	Expired
`6eadd77`	Fri, 08 Nov 2024 15:57:12 GMT	Expired	Expired
`c99da4e`	Fri, 08 Nov 2024 16:08:57 GMT	Expired	Expired
`16d6e87`	Fri, 08 Nov 2024 16:32:06 GMT	Expired	Expired
`46cee98`	Fri, 08 Nov 2024 16:51:35 GMT	Expired	Expired
`e7656bf`	Fri, 22 Nov 2024 17:59:19 GMT	Expired	Expired
`1b2852e`	Fri, 22 Nov 2024 18:30:29 GMT	Cloud	Enterprise

…v/gazebo into rvinnakota/add-select-all

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.tsx

spalmurray-codecov · 2024-11-18T20:09:24Z

src/ui/Checkbox/Checkbox.tsx

I don't really like adding this usage specific logic to the generic component like this. IMO a better approach might be adding CVA variants for check (default) and minus then you can control the state out of here, passing in the variant as a prop. Lmk what you think.

<Checkbox checked={true} variant='minus' /> <Checkbox checked={true} /> <Checkbox checked={false} />

See ui/Card/Card.tsx for example of CVA variants

Ahhhh wait CVA won't work for the icon as it's not css

Looking at the designs, I think an optional prop just for the icon type would work:

<Checkbox icon='minus' checked={true} />

This would clean the component up quite a bit.

spalmurray-codecov · 2024-11-18T20:18:12Z

src/ui/Icon/svg/outline/index.jsx

This isn't the correct method for adding icons, so it'll get reverted next time someone generates them the correct way. The correct way is:

Add the name to scripts/icon-list.mjs

yarn run generate-icons

If you do this and notice icons being removed in the diff, you may need to fix those as well. This process has been poorly communicated on the team I think lol

spalmurray-codecov · 2024-11-18T20:19:01Z

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.tsx

+    }))
+  }
+
+  const determineCheckboxCheckedState = (title: string) => {


I think with my suggested changes in Checkbox, we could remove this function.

spalmurray-codecov

Some things I noticed happy to talk through anything 🫡

…ota/add-select-all

rohitvinnakota-codecov · 2024-11-22T17:18:11Z

@codecov-ai-reviewer review

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.tsx

Update

9109ea9

rohitvinnakota-codecov and others added 6 commits November 7, 2024 09:53

Update

8a5d97d

Undo

fa93a38

Merge branch 'main' into rvinnakota/add-select-all

5c3b56e

Tests

618914e

Merge branch 'rvinnakota/add-select-all' of https://github.com/codeco…

aeab8ee

…v/gazebo into rvinnakota/add-select-all

Reverse

d316c27

rohitvinnakota-codecov and others added 7 commits November 8, 2024 10:40

Refactor

a62920b

Update

fcfa2c1

Styling update

6eadd77

Merge branch 'main' into rvinnakota/add-select-all

c99da4e

Update style

3f7b478

Merge branch 'rvinnakota/add-select-all' of https://github.com/codeco…

16d6e87

…v/gazebo into rvinnakota/add-select-all

Clean code

46cee98

rohitvinnakota-codecov changed the title ~~[draft] Add a select all checkbox in the uploads card~~ [feat] Add a select all checkbox in the uploads card Nov 8, 2024

rohitvinnakota-codecov marked this pull request as ready for review November 8, 2024 16:54

spalmurray-codecov reviewed Nov 18, 2024

View reviewed changes

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.tsx Outdated Show resolved Hide resolved

spalmurray-codecov reviewed Nov 18, 2024

View reviewed changes

spalmurray-codecov requested changes Nov 18, 2024

View reviewed changes

codecov deleted a comment from codecov-ai bot Nov 20, 2024

codecov deleted a comment from codecov-ai bot Nov 21, 2024

Merge branch 'main' of https://github.com/codecov/gazebo into rvinnak…

f4d0504

…ota/add-select-all

codecov-ai bot reviewed Nov 22, 2024

View reviewed changes

src/pages/CommitDetailPage/CommitCoverage/UploadsCard/UploadsCard.tsx Outdated Show resolved Hide resolved

codecov deleted a comment from codecov-ai bot Nov 22, 2024

rohitvinnakota-codecov added 2 commits November 22, 2024 12:51

Update

e7656bf

fix tests

1b2852e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Add a select all checkbox in the uploads card #3470

[feat] Add a select all checkbox in the uploads card #3470

rohitvinnakota-codecov commented Nov 6, 2024 •

edited

Loading

codecov-staging bot commented Nov 6, 2024 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Nov 6, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 6, 2024 •

edited

Loading

codecov bot commented Nov 6, 2024 •

edited

Loading

codecov-staging bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading

codecov-releaser commented Nov 7, 2024 •

edited

Loading

spalmurray-codecov Nov 18, 2024

spalmurray-codecov Nov 18, 2024

spalmurray-codecov Nov 18, 2024

spalmurray-codecov Nov 18, 2024 •

edited

Loading

spalmurray-codecov Nov 18, 2024

spalmurray-codecov Nov 18, 2024

spalmurray-codecov Nov 18, 2024

spalmurray-codecov left a comment

rohitvinnakota-codecov commented Nov 22, 2024

[feat] Add a select all checkbox in the uploads card #3470

Are you sure you want to change the base?

[feat] Add a select all checkbox in the uploads card #3470

Conversation

rohitvinnakota-codecov commented Nov 6, 2024 • edited Loading

Legal Boilerplate

codecov-staging bot commented Nov 6, 2024 • edited by codecov-notifications bot Loading

Codecov Report

codecov-qa bot commented Nov 6, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Nov 6, 2024 • edited Loading

❌ 2 Tests Failed:

codecov bot commented Nov 6, 2024 • edited Loading

Codecov Report

codecov-staging bot commented Nov 7, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 7, 2024 • edited Loading

Bundle Report

codecov-releaser commented Nov 7, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

spalmurray-codecov Nov 18, 2024

Choose a reason for hiding this comment

spalmurray-codecov Nov 18, 2024

Choose a reason for hiding this comment

spalmurray-codecov Nov 18, 2024

Choose a reason for hiding this comment

spalmurray-codecov Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

spalmurray-codecov Nov 18, 2024

Choose a reason for hiding this comment

spalmurray-codecov Nov 18, 2024

Choose a reason for hiding this comment

spalmurray-codecov Nov 18, 2024

Choose a reason for hiding this comment

spalmurray-codecov left a comment

Choose a reason for hiding this comment

rohitvinnakota-codecov commented Nov 22, 2024

rohitvinnakota-codecov commented Nov 6, 2024 •

edited

Loading

codecov-staging bot commented Nov 6, 2024 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Nov 6, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 6, 2024 •

edited

Loading

codecov bot commented Nov 6, 2024 •

edited

Loading

codecov-staging bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading

codecov-releaser commented Nov 7, 2024 •

edited

Loading

spalmurray-codecov Nov 18, 2024 •

edited

Loading