-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We'd love your feedback! #1
Comments
Oha |
I have a massive problem on the UI actually. I have a branch that shows my coverage without any problems and when i go to main screen where it's the same branch that i setup as default says there are no files to compare and doesn't show my files but shows coverage just files aren't accessible from there. Otherwise i love Codecov. It's just great! And the new design is great! |
@kylemann great to see UI improvements landing. Since you asked, here's some feedback based the things you mentioned you were looking for... What do you think about the new UI changes?I just saw the new logged-in landing page for the first time. Definitely a nice improvement! I like the table of repos/date updated/coverage %. Makes it really easy to digest the information at-a-glance, and it's then easy to navigate into each repo 👏 What are challenges you've experienced?One thing that's always been confusing for me: personal github account vs. organization within the CodeCov UI. I manage my company's CodeCov account - my company has multiple repos using CodeCov, but I have no personal repos using CodeCov. Often the CodeCov UI will toggle to my personal GitHub Context. It's not always clear when this happens, so I'm frequently left wondering "where did my repos go", "where did my users go", "why does it say I'm not on a paid plan", etc. until I realize the account Context switched. The new Context menu in the top left definitely helps make this more obvious, so nice job there. But it would be even better if the confusion could be minimized further. Some possible solutions could be:
How do you use the tool today? What parts do you use?
How could we better help your workflow?We frequently try to identify the biggest coverage gaps/opportunities. We also consider other aspects like "how valuable is coverage in this area", "how many bugs are we seeing in this area", "will this code be changing anytime soon", etc., but starting with the gap analysis is useful in order to then ask more questions about it. The sunburst chart is helpful here, but for a large repo it can be difficult to hover over all the slices. So I typically use the directory listing instead. The visual "percentage coverage" bars are useful here (in the "Coverage" column of the table), but percentage is relative - if I have 10% coverage on a directory that has 10 lines of code, that's much less of a coverage gap than a directory that has 10% coverage on 10,000 lines of code - but the bar shading makes the coverage look the same for both of those directories. So I wind up sorting the directory table by "lines missed", which tells me where my gaps are in absolute terms. It would be neat if CodeCov could make the absolute coverage gaps more clear in some way. Or maybe you could automatically surface "biggest gaps/risks/opportunities" in some way, like listing the top 10 directories with the most lines missed or similar. Thanks again for investing further in the UI, and for reaching out for feedback! |
I like the UI, but I've had problems with diffs not showing up and login not working across all domains for a while. I made a video to make the issue more apparent to you: This is for https://github.com/binwiederhier/replbot but it happens on other repos too. |
Hello @binwiederhier, @CHSchiaffino, @jonaldinger, @nikiizvorski. |
Thanks for responding. For what it's worth. Logging out and logging back in fixed that issue. Another thing I found a little odd is the new(?) diff view where the lines are not fully highlighted anymore, but only marked red/yellow/green on the side. I can't find that view right now, but I do like the old one where the lines are fully green/red much better. |
@binwiederhier I think you may still be seeing the current (not new UI). But if you come across it again, could you drop a screenshot of the section/Ui you're describing. 🙏 |
@nikiizvorski Could you send a screenshot or URL of the UI you are referencing to? I was just trying to identify the issue with our support team and wasn't able to. 🙏 |
I added this project: https://app.codecov.io/gh/import-js/eslint-plugin-import/ but it isn't showing up on https://app.codecov.io/gh?search=import, despite re-syncing multiple times. (unrelated, the default branch still seems to default to "master" despite github a) reporting this info in their API, and b) changing the default on new repos to "main" awhile ago) |
|
I would like to suggest to start the sunburst graph at the folder level that contains the first actual code file. Currently, our sunburst graph starts at src/, while our code starts at src/main/java/nl/appname/. To get the richer perspective, we now first need to click. |
I would prefer the full line background highlight (in the old UI) instead of a narrow colored gutter on the left. May I please have a chance to get it back? In some rare cases, the page margins in the new file viewer are totally lost. I think it would happen if the browser was maximized on an exactly 1280px screen. Most of the time, the page components flows responsively on resizing of browser window. The following screenshot shows one little bad case. |
@Arnie97 thank you for your feedback! It's greatly appreciated and very helpful.
Yes. The file viewer will soon be seen on the commit details and later on the compare page. As the new UI is released there will be a toggle to view the old UI, while we finalize the new UI transition and collect feedback like this for improvement. |
Dunno if it's related to your web app update effort but the coverage reports stopped being processed a day or two ago: https://community.codecov.com/t/error-processing-coverage-reports-with-github-actions/3251/4?u=webknjaz. FYI. |
That turned out to be a bug in the uploader (codecov/uploader#413 / codecov/uploader#411). Meanwhile, here's a legit new UI bug: CI job links in the |
@webknjaz Thank you for you note! |
TBH code is text. And text is most readable in narrow columns, that's why newspapers and magazines don't do edge-to-edge lines — it's weird and makes your eyes jump from side to side. (see also: typography) But it may indeed be reasonable to make the representation more centralized rather than just shifted to the right. Or maybe add an ability to collapse the left column, or introduce some sort of a "Zen mode". |
If that were universally true, books would have multiple columns too. Newspapers optimize for something different than code viewers need to. |
Books do this too. If it's just "one column", they just adjust the font size or margins not to exceed the maximum readable character length (between 45 and 75 chars). |
Then i think we’ve read very different sets of books :-) |
@dpelle Thank you for the feedback, it makes sense. Our team is looking at improving this with upcoming iterations. |
👋 @webknjaz @ljharb @vinniefalco Thank you for sharing feedback and different perspectives on the new UI. It helps our team as we are weighing the different tradeoffs for iterations along the way. In the interim, the former UI is still the default and available while we finish releasing and updating all new pages.
💯 @webknjaz I like this! Another thing we are considering for improved code viewer readability: is having a fluid layout (user can toggle either fluid or fixed). The example below shows a fluid version; which aims to optimize the whole available browser window, while also showing all the elements in space and not time (data hidden behind tabs). Again, the user could toggle in settings between the fluid or fixed. wdyt? |
@codecovdesign that sounds reasonable. One comment, though: the "Uploads" block is not essential in this view, normally I only need it if something goes wrong and I'm trying to figure out if some reports didn't reach Codecov. I don't imagine any other use-cases. That said, I'd maybe show it on request but not by default. OTOH this empties up a lot of space depending on the height of the code section. Which would be fine in a one-column view with equal margins on both sides keeping that content easy to focus on without distractions. In case, when the uploads are not shown, the "Coverage report" block may make sense to be relocated on top of the file content view (and made less tall). I mean, of course, the overall coverage is the most important piece of info about the commit but I've probably seen it before navigating to the commit details page and want to focus on finding out the reason behind the drop or other data, right? |
it isn't though, the green highlight does not extend across the line, only in the gutter. |
One thing I took out of original comment because it was getting too long and adding nuance wouldn't help. I would still claim that allowing the user to choose the default number of lines in the top UI of the table |
@vinniefalco, understood. I know about gallows humor. I am currently working as an EMT. Have been once since college in the 80's. |
I miss the sun diagram on the main page, it gave a good overwrite of project coverage, instead now I just have 2 folders in a list that i have to drill in to/get lost in, not very informative. The flags feature is presented in a way that makes it appear critical but I have both had trouble enabling it and concluded that its not actually relevant for any of my projects. I also miss delta from the commits/pr page, it now only shows total and diff (the new way of presenting them is easier to understand) |
The new time line graph that is presented instead of the sun diagram also doesn't scale to the content with makes it kinda ussels for some projects: I realize that it allows scrolling, but to call that intuitive is an understatement. X and Y scroll at the same time, and its happy to place you somewhere outside the data |
I primarily use Codecov for insight on pull requests (now that the sunburst is removed for some reason) and what really bothers me and still surprises me every time I try it is that the impacted files all lead to the same page. What's the point of making all the file names clickable if the page they lead to is useless? Each time I think that when I click on a file that's missing coverage I will be taken to a page showing me information about that file. And each time I'm disappointed. |
Hi Vinnie: It looks like you are viewing a pull. Have pulls and commits ever have a branch selector? I only remember it at the top repo level, but I might be mistaken. If it was there, it would have to take you back to the top repo level since a pull or commit is only applicable to a single branch right? Oh I think I see what you mean: The old view had:
menu items in all screens. And yes, branches jumped you out of commits/pulls. Commits still has the branch selector as well as Coverage in the new app. But you can't get there without -- rouilj |
Yes I can get to the branch selector but only the branches of the upstream repo appear, not the pull request branch / commits. Yes I used to be able to see the file view for individual pull requests. |
@vinniefalco Re: the branch selector, can you expand on what you're trying to do and/or ideal state would be? |
Me? I was just rooting around looking for the files view. |
@vinniefalco thank you for your feedback. Specifically your points about screen sizing, inline scrolling, expand view, open new tab (not sure why that'd not work) are all very helpful and we're on it. I invite your feedback and it's greatly appreciate it, but disparaging comments about our teammates are not acceptable - please stop. We have a dedicated team that is working hard daily to iterate and improve the app. |
Echoing the desire for a list of all files on the pull request view. I've got a (flakey, probably) test on a pull request that's listed as If the codecov backend has information about what files have seen any change to coverage at all, it would be very useful to show all of those files too, even if there were no code changes made to them in the pull request. |
My team is putting the finishing touches on a beautiful new set of report templates for gcov which replicate the original codecov interface experience. If anyone has screenshots of the original source file view, source file view with commit diffs, source file view with coverage diffs, and source file view with total coverage or knows where to look to find them please message me (email in my GitHub bio) - these templates will be free and open source. |
Also, I've been gone for quite a few months and I'm somewhat pleased to see unequivocal improvements to some of the previous issues; However there are still elements which need work. |
Nice! Looking forward to seeing the results – I'll email you a few screen shots I have.
Indeed. Would love to jump on a call and walkthrough your thoughts further. I'll add invite to my email to you. Lastly, we will be closing this issue soon. We'll be setting up a new repo to add issues and feedback - more on this topic coming soon - in the interim we do have a feedback forum. |
Logging in to my account. List of orgs and repos this seems OK: Scrolling down a bit, ok now things are getting weird. The organizations are not sorted? Oh, I get it, I guess... they are sorted by repository name. But wait that can't be right, they are sorted by "last updated." Oh I can't change the sort by clicking on the column. Whatever, its just the repository list who cares. Oh well, "about 1 month ago" is wrapping. Now the row is larger so list items are not evenly spaced: That is unfortunate because I do feel like my windows is pretty wide... surely we can fit everything in there without the need to wrap? Well lets click on one of the repos. This seems inoffensive at first glance: Wait a sec what's with the baseline of the branch name text not aligned vertically with the rest of the path? Ooops, another unaligned baseline. Seems to be a common theme, two pixels off here: Now, the green background of this text is not wrong per se, but it is not aesthetically pleasing, because the characters butt right up to the edge: You could throw a space before and after that text, and it could look like this: I would go with a rounded corner rectangle myself since it goes with the new font you chose (which I hate): |
@vinniefalco thanks for sharing this feedback!
Agreed, it should indicate what the sort is! You'll notice some headers have the sort ability – there is a
Noted - will investigate...what browser are you using?
agreed, great suggestion!
I was hoping you'd noticed that our numerals on the tables are Lato (tabular) - our OG font / your preference 😢 @vinniefalco thanks again for the report 🙏 |
Those are all I looked at but I will look at the other pages soon |
I'm still a bit confused about the numbers displayed on a PR such as these: https://app.codecov.io/gh/kupka/libsrd5/pull/27 I get it that the -0.04% is the difference between main (100%) and the branch head (99.96%). However, placing the -0.04% after the 99.96% (head) and 99.54% (patch) makes me always feel that this is basically flawed arithmetic. I still haven't figured out what the "patch" value in this case means, especially when the only file that has missed lines looks like this: With head% and patch% both at 96.59%. All other files are displaying head/patch at 100% so I don't really get the difference with the numbers on top. |
Hello 👋 Thank you for all the contributions and great feedback in this issue. We are closing this issue, but would love your feedback here:
🙏 |
Thanks for your support, surly your advice and help is needed as am newbee too. |
The C++ Alliance has sponsored Frank Wiles' work to add customizable templates to gcovr. This will allow for more profound customizations than before, using stock gcovr. It is our goal to produce templates similar to how codecov used to look before the UI was "improved." You can see that work here: |
Thanks for dropping by! 👋
We've been iterating and updating the web app experience and would love your feedback about:
We greatly appreciate your time and thoughts - looking forward to hearing from you ❤
Codecov team
This issue is intended to share and collect feedback about the tool. If you have support needs or questions, please see our support page.
The text was updated successfully, but these errors were encountered: