Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits from the merge queue should be also shown in the main branch #216

Open
rohan-at-sentry opened this issue Jan 8, 2024 Discussed in #98 · 3 comments
Open

Commits from the merge queue should be also shown in the main branch #216

rohan-at-sentry opened this issue Jan 8, 2024 Discussed in #98 · 3 comments
Labels
Support For general support questions, e.g. onboarding or configuration Waiting for: Product Owner

Comments

@rohan-at-sentry
Copy link

Discussed in #98

Originally posted by justinchuby October 13, 2023
We recently enabled codecov for the onnx/onnx repository. One of the things we discover is there is no "main" branch from the drop down:

image

Turns out the commits from the merge queue branch gh-readonly-queue/* are the same commits in main (e.g. https://app.codecov.io/gh/onnx/onnx/commit/b61d2a8ab7a7e60eb386a387c73e449dd3461b3e), but codecov does not show these commits as part of the main branch. This causes the portal to show no "main" branch at all for coverage data, which can be inconvenient and confusing.

@covecod covecod bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jan 8, 2024
@rohan-at-sentry rohan-at-sentry added Waiting for: Support Support For general support questions, e.g. onboarding or configuration and removed Waiting for: Product Owner labels Jan 8, 2024
@covecod covecod bot removed the status in GitHub Issues with 👀 Jan 8, 2024
@covecod covecod bot moved this to Waiting for: Support in GitHub Issues with 👀 Jan 8, 2024
@drazisil-codecov
Copy link

drazisil-codecov commented Jan 9, 2024

@justinchuby,

Codecov is not aware that a branch exists until coverage is uploaded from it. Is it possible for you to have your CI upload coverage again after the PR is merged?

@rohan-at-sentry ,

Additionally, Codecov does not currently support commits existing on multiple branches, see #178

@drazisil-codecov drazisil-codecov moved this from Waiting for: Support to Waiting for: Community in GitHub Issues with 👀 Jan 9, 2024
@justinchuby
Copy link

Is it possible for you to have your CI upload coverage again after the PR is merged?

Do you have a recommended workflow for doing this?

@covecod covecod bot moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 Jan 9, 2024
@drazisil-codecov
Copy link

Is it possible for you to have your CI upload coverage again after the PR is merged?

Do you have a recommended workflow for doing this?

Depending on the CI workflow, you may be able to save the coverage report as an artifact somewhere. Then have a job that runs on main that:

  • Checks out the code (needed for the upload)
  • Downloads the coverage report
  • Runs the uploader to upload the coverage report under the new merged SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support For general support questions, e.g. onboarding or configuration Waiting for: Product Owner
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

3 participants