Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun rendering of files #103

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

angelina-momin
Copy link
Collaborator

@angelina-momin angelina-momin commented Sep 6, 2024

Something went wrong with the files in the last PR link (even though I checked before opening the PR for review). Rendering the files again.

The files reflect changes in the codecheck PR link

@angelina-momin
Copy link
Collaborator Author

Merging without review since the files are related to the merged codecheck PR link

@angelina-momin angelina-momin merged commit 0aef311 into master Sep 6, 2024
@angelina-momin angelina-momin deleted the Rerun-render-non-register-files branch September 6, 2024 11:24
@nuest
Copy link
Member

nuest commented Sep 6, 2024

I think the issue could be that the image for rending the register is built in this repo.

And since I added a change to the register.csv to you previous PR, the rendering process was triggered, and was probably using an old image. Or something like that.

Sorry for the mess! Looks all good now!

Maybe this will make our lives easier: #105

@nuest nuest added the check-nl Part of the 2024 NWO funded project "CODECHECKing goes NL" (CHECK-NL) label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-nl Part of the 2024 NWO funded project "CODECHECKing goes NL" (CHECK-NL)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants