Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix servicemonitor http endpoint #791

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

FranckKe
Copy link
Contributor

Fix issue with servicemonitor trying to read .Values within a loop

Reproduction before fix

❯ helm template --set extraServiceMonitor.enabled=true ./
Error: template: keycloakx/templates/servicemonitor.yaml:37:24: executing "keycloakx/templates/servicemonitor.yaml" at <.Values.http.internalScheme>: nil pointer evaluating interface {}.http

Signed-off-by: Franck Kerbiriou <[email protected]>
@FranckKe FranckKe requested a review from a team as a code owner August 26, 2024 17:56
@joggeli34
Copy link

We stumbled over the same issue. Can the PR be merged and released soon?
Thanks

@gerruite
Copy link

gerruite commented Aug 28, 2024

We encountered this problem too. I also found this to be the cause and I'm happy to see an open PR

keycloak   103s   False   Helm install failed for release keycloak/keycloak with chart [email protected]: template: keycloakx/templates/servicemonitor.yaml:37:24: executing "keycloakx/templates/servicemonitor.yaml" at <.Values.http.internalScheme>: nil pointer evaluating interface {}.http

@ethan-k
Copy link

ethan-k commented Aug 30, 2024

Workaround while waiting for this PR to be merged

In your helm chart,

serviceMonitor:
  Values:
    http:
      internalScheme: http

@pascal-sochacki pascal-sochacki merged commit 8371ce7 into codecentric:master Aug 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants