Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Base64QRCode on .NET6+ on Linux #495

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Apr 13, 2024

Summary

This PR allows Base64QRCode to be used with .NET 6+ on Linux as long as the requested image type is PNG.

Test plan

Tests have been added to the codebase

Closing issues

Fixes:

@Shane32
Copy link
Contributor Author

Shane32 commented Apr 13, 2024

@codebude Along with supporting SVG and PDF files on Linux, adding support for base64-encode PNG files is rather simple; PNG is the default encoder for Base64QRCode anyway. It also provides a notable performance optimization for base64-encoded PNG files regardless of platform.

QRCoder/Base64QRCode.cs Show resolved Hide resolved
QRCoder/Base64QRCode.cs Show resolved Hide resolved
QRCoder/Base64QRCode.cs Outdated Show resolved Hide resolved
QRCoder/Base64QRCode.cs Outdated Show resolved Hide resolved
QRCoder/Base64QRCode.cs Outdated Show resolved Hide resolved
QRCoder/Base64QRCode.cs Outdated Show resolved Hide resolved
QRCoder/Base64QRCode.cs Outdated Show resolved Hide resolved
QRCoder/QRCoder.csproj Show resolved Hide resolved
@Shane32
Copy link
Contributor Author

Shane32 commented Apr 24, 2024

I've made suggestions based on your comments; please review again @codebude - thanks!

@codebude
Copy link
Owner

@Shane32 looks good.

Reminder to myself: update change log and compatibility matrix.

@codebude codebude merged commit 6ec439e into codebude:master Apr 25, 2024
3 checks passed
@Shane32 Shane32 deleted the support_base64_linux branch April 25, 2024 07:22
@aligneddev
Copy link

We just ran into this issue and I was thankful to see this PR is merged in.

I'm sure you have a lot of testing and things going on, so please forgive my eagerness, but do you have a timeline for the next release?

Thanks for all your work @codebude and @Shane32!

@codebude
Copy link
Owner

codebude commented Apr 25, 2024

Hi @aligneddev

[...] but do you have a timeline for the next release?

Yesterday! Joking aside, there is only one open PR (#503) left, which I would like to review and merge, before I release the next version (1.5.0). So if nothing unforseen happens, you can expect the release within the next 2-3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants