-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Base64QRCode on .NET6+ on Linux #495
Conversation
@codebude Along with supporting SVG and PDF files on Linux, adding support for base64-encode PNG files is rather simple; PNG is the default encoder for Base64QRCode anyway. It also provides a notable performance optimization for base64-encoded PNG files regardless of platform. |
I've made suggestions based on your comments; please review again @codebude - thanks! |
@Shane32 looks good. Reminder to myself: update change log and compatibility matrix. |
Hi @aligneddev
Yesterday! Joking aside, there is only one open PR (#503) left, which I would like to review and merge, before I release the next version (1.5.0). So if nothing unforseen happens, you can expect the release within the next 2-3 days. |
Summary
This PR allows
Base64QRCode
to be used with .NET 6+ on Linux as long as the requested image type is PNG.Test plan
Tests have been added to the codebase
Closing issues
Fixes: