Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a page for challenges #53

Merged
merged 12 commits into from
Feb 13, 2016

Conversation

karimamer
Copy link
Contributor

closes #51
this pull requests adds a dynamic way of creating challenge pages

@karimamer
Copy link
Contributor Author

@rogerhoward @davidnuon the content needs to be reviewed. page titles and the first challenge page

@rogerhoward
Copy link
Contributor

I'll test this, but I'm not going to merge it until we have actual content.

@karimamer
Copy link
Contributor Author

👍

@rogerhoward
Copy link
Contributor

I think this is a good example of the issue i noted as "a branch should represent an atomic change" in our contributions guide discussion - if I merged this PR it'd end up posting incomplete content directly to the site. We could either pull the sample content out so the functionality is there but won't do anything yet, or add final content if we have some. I'm going to add content tonight to support this week's challenge, just wanted to note my thinking on this PR.

@karimamer
Copy link
Contributor Author

agreed reference to the discussion #38

@rogerhoward
Copy link
Contributor

After reviewing, this PR isn't ready for merge - page still needs cleanup, proper headers, some context. I'll work on this tonight.

@karimamer
Copy link
Contributor Author

@rogerhoward that is what i thought. thanks for reviewing this i can add the changes if you don't have time

@rogerhoward
Copy link
Contributor

I'm going ahead and merging this - thanks for your work!

rogerhoward added a commit that referenced this pull request Feb 13, 2016
…e-for-challenges

 add a page for challenges
@rogerhoward rogerhoward merged commit 12fe350 into development Feb 13, 2016
@rogerhoward rogerhoward deleted the enhancement/#51-add-a-page-for-challenges branch February 16, 2016 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a page for code and coffee challenges
2 participants