-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a page for challenges #53
add a page for challenges #53
Conversation
@rogerhoward @davidnuon the content needs to be reviewed. page titles and the first challenge page |
I'll test this, but I'm not going to merge it until we have actual content. |
👍 |
I think this is a good example of the issue i noted as "a branch should represent an atomic change" in our contributions guide discussion - if I merged this PR it'd end up posting incomplete content directly to the site. We could either pull the sample content out so the functionality is there but won't do anything yet, or add final content if we have some. I'm going to add content tonight to support this week's challenge, just wanted to note my thinking on this PR. |
agreed reference to the discussion #38 |
After reviewing, this PR isn't ready for merge - page still needs cleanup, proper headers, some context. I'll work on this tonight. |
@rogerhoward that is what i thought. thanks for reviewing this i can add the changes if you don't have time |
* Edited description * Changes headers and other formatting * Added solicitation for other challenges
I'm going ahead and merging this - thanks for your work! |
…e-for-challenges add a page for challenges
closes #51
this pull requests adds a dynamic way of creating challenge pages