-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add cypress #20
base: main
Are you sure you want to change the base?
Conversation
closes #13
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/code4romania/vot-diaspora-v2/nxjq2ymix |
I think we should add the tests in this PR before we merge in master. |
I wanted to keep the changes separate (testing setup vs actual tests) as I am planning to add same testing setup to https://github.com/code4romania/vot-romania-client (not strong reason) As such I don't have much against adding the tests in this PR, but wanted to hear your argument @Utwo |
We had some repos in the past that ended with Cypress setup in the CI and with just one or two actual tests. Cypress is pretty big and it will slow down the CI for what in the end is just a simple static website. I'm a big advocate to KISS principle and I would say that for a simple one page website with just two functionality there is no need for complex tooling, that's why I would suggest to not add cypress on vo-romania-client. I'm sure there are other more complex projects that needs a couple of tests more then the vot-* ones. But anyway, in the end, it will be @RaduCStefanescu call. |
That becomes a problem only if you foresee a big flux of contributions to this repo.
Any website needs testing. If it's not automated, it needs to be done manually. @RaduCStefanescu this is now a discussion about testing strategy and not the implementation in the MR, so we need your input. |
What does it fix?
Adds test setup
Closes #13