Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cypress #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: add cypress #20

wants to merge 2 commits into from

Conversation

tehciolo
Copy link
Contributor

@tehciolo tehciolo commented Nov 5, 2020

What does it fix?

Adds test setup

Closes #13

@vercel
Copy link

vercel bot commented Nov 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/vot-diaspora-v2/nxjq2ymix
✅ Preview: https://vot-diaspora-v2-git-13-testing-setup-redux.code4romania.vercel.app

@Utwo
Copy link
Member

Utwo commented Nov 6, 2020

I think we should add the tests in this PR before we merge in master.

@tehciolo
Copy link
Contributor Author

tehciolo commented Nov 6, 2020

I think we should add the tests in this PR before we merge in master.

I wanted to keep the changes separate (testing setup vs actual tests) as I am planning to add same testing setup to https://github.com/code4romania/vot-romania-client (not strong reason)

As such I don't have much against adding the tests in this PR, but wanted to hear your argument @Utwo

@Utwo
Copy link
Member

Utwo commented Nov 9, 2020

We had some repos in the past that ended with Cypress setup in the CI and with just one or two actual tests. Cypress is pretty big and it will slow down the CI for what in the end is just a simple static website.

I'm a big advocate to KISS principle and I would say that for a simple one page website with just two functionality there is no need for complex tooling, that's why I would suggest to not add cypress on vo-romania-client. I'm sure there are other more complex projects that needs a couple of tests more then the vot-* ones.

But anyway, in the end, it will be @RaduCStefanescu call.

@tehciolo
Copy link
Contributor Author

Cypress is pretty big and it will slow down the CI for what in the end is just a simple static website.

That becomes a problem only if you foresee a big flux of contributions to this repo.

I'm a big advocate to KISS principle and I would say that for a simple one page website with just two functionality there is no need for complex tooling, that's why I would suggest to not add cypress on vo-romania-client.

Any website needs testing. If it's not automated, it needs to be done manually.

@RaduCStefanescu this is now a discussion about testing strategy and not the implementation in the MR, so we need your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing setup
3 participants