Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable sign in button when firefox autofills credentials #1651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fyzanshaik
Copy link

@fyzanshaik fyzanshaik commented Dec 12, 2024

PR Fixes:

  • Fixed an issue where the submit button wasn't disabling on Firefox when autofill was used.
  • Optimized the autofill detection logic by moving it to a dedicated useEffect for better performance and readability.

Resolves #[1650]

Screencast.From.2024-12-12.17-53-32.mp4

Checklist Before Requesting a Review:

  • I have performed a thorough self-review of my code to ensure quality and adherence to best practices.
  • I confirm that no similar or duplicate pull requests exist for the same issue or functionality.

@fyzanshaik
Copy link
Author

ping @devsargam @hkirat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant