Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-setup): add custom path matcher to vitest, add tests #876

Merged
merged 23 commits into from
Jan 6, 2025

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Nov 19, 2024

This PR includes:

  • the custom matcher
  • typings
  • tests
  • several adjustments to make the e2e test more stable by not testing warnings
  • the create-cli-e2e tests are disabled until the new package is released

Copy link

github-actions bot commented Nov 19, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit c7e902b with source commit c219602.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🟡 56 ↑ +0.9
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 81 🟡 81
Updates 🟡 80 🟡 80
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 5 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🟡 56 ↑ +0.9
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 4.8 s 🟨 5.4 s ↑ +12.6 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.1 s ↓ −10.8 %
Lighthouse Time to Interactive 🟥 12.8 s 🟥 13.5 s ↑ +5.1 %
Lighthouse Total Blocking Time 🟥 3,280 ms 🟥 4,600 ms ↑ +40.2 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 2.7 s ↓ −0.9 %
Code coverage Line coverage 🟩 90.9 % 🟩 90.5 % ↓ −0.4 %
Code coverage Branch coverage 🟨 85.8 % 🟨 85.6 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,816 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 5.5 s 🟥 8.0 s ↑ +45.1 %
Lighthouse Minimizes main-thread work 🟥 13.8 s 🟥 15.6 s ↑ +12.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +5.1 %
Lighthouse Max Potential First Input Delay 🟥 2,140 ms 🟥 2,020 ms ↓ −5.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 66 KiB 🟥 Potential savings of 66 KiB ↓ −23.1 %
Lighthouse Server Backend Latencies 🟩 160 ms 🟩 80 ms ↓ −51.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↑ +0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 940 ms 🟥 Potential savings of 910 ms ↓ −3 %
Lighthouse Initial server response time was short 🟩 Root document took 390 ms 🟩 Root document took 360 ms ↓ −6.6 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 20 ms ↑ +64.6 %
Lighthouse Avoids an excessive DOM size 🟥 2,142 elements 🟥 2,141 elements ↓ −0.1 %

569 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review December 10, 2024 18:24
@BioPhoton BioPhoton requested a review from matejchalk December 10, 2024 18:24
@BioPhoton BioPhoton enabled auto-merge (squash) December 10, 2024 18:25
testing/test-setup/vite.config.unit.ts Outdated Show resolved Hide resolved
testing/test-setup/src/lib/extend/path.matcher.ts Outdated Show resolved Hide resolved
testing/test-setup/src/lib/extend/path.matcher.ts Outdated Show resolved Hide resolved
testing/test-setup/src/lib/extend/path.matcher.ts Outdated Show resolved Hide resolved
testing/test-setup/src/lib/extend/path.matcher.ts Outdated Show resolved Hide resolved
testing/test-setup/src/lib/extend/path.matcher.ts Outdated Show resolved Hide resolved
testing/test-setup/src/vitest.d.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton requested a review from matejchalk January 5, 2025 22:56
@BioPhoton BioPhoton merged commit cedf140 into main Jan 6, 2025
17 checks passed
@BioPhoton BioPhoton deleted the test-custom-matcher-paths-os-agnostic branch January 6, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants