Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update token sale contract to exclude vesting #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update token sale contract to exclude vesting #45

wants to merge 2 commits into from

Conversation

HickupHH3
Copy link
Contributor

No description provided.

MrToph
MrToph reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@MrToph MrToph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I noticed the changeWhiteList still uses tokenLock for some vesting look up that shouldn't be strictly necessary anymore?

@HickupHH3
Copy link
Contributor Author

Removed tokenLock & vestDuration as well

@MrToph
Copy link
Contributor

MrToph commented Mar 15, 2023

Oh, now you'd need to adjust the deployments etc. because the number of args changed/reduced + tests fail, right? I'll leave it up to you if you want to keep the same contract interface (with the vesting) and just not call it inside the contract. Whatever is easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrToph MrToph MrToph left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HickupHH3 @MrToph