Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests: handle interrupts when halted in the request loop #585

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

msft-jlange
Copy link
Collaborator

If the request loop determines that there is no active VMSA, the processor enters a halt state. This halt state can terminate if an interrupt is received. If that happens, the request loop will observe that no change to the VMSA mapping has been requested. In this case, the request loop must return to the halt state rather than attempting to process any requests.

If the request loop determines that there is no active VMSA, the
processor enters a halt state.  This halt state can terminate if an
interrupt is received.  If that happens, the request loop will observe
that no change to the VMSA mapping has been requested.  In this case,
the request loop must return to the halt state rather than attempting to
process any requests.

Signed-off-by: Jon Lange <[email protected]>
@msft-jlange
Copy link
Collaborator Author

@joergroedel, this is needed to make the IPI unit tests pass correctly. Without this change, the tests will pass, but all APs will panic after the IPI test has completed because they cannot handle the wake from halt properly. It is posted as a separate PR because it can merge separately.

Copy link
Member

@joergroedel joergroedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joergroedel joergroedel merged commit 3d25be0 into coconut-svsm:main Jan 7, 2025
4 checks passed
@msft-jlange msft-jlange deleted the request_hlt branch January 7, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants