testing: support configurations other than SNP/QEMU #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-jlange
force-pushed
the
test-in-hv
branch
from
0a271fc to
7873cf3
Compare
joergroedel
reviewed
Dec 17, 2024
Tests that require interaction with a QEMU-based test environment (such as specific I/O ports) should only be invoked when running in that test environment. Signed-off-by: Jon Lange <[email protected]>
Tests specific to the functionality of SNP platforms (such as #VC handling and guest request messages) should only be performed on SNP platforms. Signed-off-by: Jon Lange <[email protected]>
msft-jlange
force-pushed
the
test-in-hv
branch
from
7873cf3 to
38f1952
Compare
joergroedel
reviewed
Dec 20, 2024
There was a problem hiding this comment.
The changes work as proposed. But longer term I think the way the platform checks are done in the test cases will cause some problems. We should think about a better way to make the test-cases hypervisor specific, maybe by introducing per-hypervisor feature names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test-in-svsmbuild configuration should support environments other than SNP running on QEMU.