Narrow and Clarify Label Conditions for Matching in Evaluation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check only for void, since the sanity checks cover other missing conditions p.s. the truth and prediction IDs were incidentally float after the division and modulus operations, although I'm not sure why, so they're cast back to integer type for comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sanity checks cover other missing prediction label conditions, and the ground truth can be assumed consistent (famous last words) across the json and png, so the only necessary checks are for skipping void.
I don't know why the IDs are turning into float types, but I'm casting them back since they're integral elsewhere like in the data format.