tasks: Install full chromium #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headless version has several bugs, at least [1] and [2]. Also, headless and full Chromium render texts slightly differently, so we can't debug/fix pixel tests with `TEST_SHOW_BROWSER=pixels`. This is a net 100 MB size increase of the tasks container, and will break all pixel tests once, but long-term it is a better browser. [1] https://issues.redhat.com/browse/COCKPIT-1159 [2] cockpit-project/cockpit-files#911 (comment)
|
Doing the first refresh in cockpit-project/cockpit-files#912 and cockpit-project/cockpit-podman#1973 |
jelly
approved these changes
Jan 20, 2025
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Jan 20, 2025
In cockpit-project/cockpituous#637 we moved the tasks container to full chromium. As our pixel tests are now calibrated to that instead of -headless, also prefer running the full chromium over headless.
jelly
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Jan 21, 2025
In cockpit-project/cockpituous#637 we moved the tasks container to full chromium. As our pixel tests are now calibrated to that instead of -headless, also prefer running the full chromium over headless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headless version has several bugs, at least [1] and [2]. Also, headless and full Chromium render texts slightly differently, so we can't debug/fix pixel tests with
TEST_SHOW_BROWSER=pixels.This is a net 100 MB size increase of the tasks container, and will break all pixel tests once, but long-term it is a better browser.
[1] https://issues.redhat.com/browse/COCKPIT-1159
[2] cockpit-project/cockpit-files#911 (comment)