storaged: btrfs helper cleanups #21504
Open
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't be on persistent storage -- after a reboot all the mounts are gone, so the database should not survive that either. Use `os.path.join()` for a slightly more regular and cleaner path building. Move the database on package upgrades, to not break new cockpit sessions in the current boot.
This will re-use already existing mounts from monitoring, but avoid extra additional mounts to become visible in the file system for `btrfs-tool poll` commands. Move the `--make-rprivate` into `unshare_mounts()` to avoid repetition.
martinpitt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't yet understand enough of what's going on here to eliminate all persistent mounts (in particular, the
monitorones), but this should at least improve the situation.