login: Fix quote removal in brand name #21498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arch failure is subtle -- we actually show "Arch Linux " (with a trailing space). ubuntu is more subtle - its branding says |
Don't cut off the last character from brand names if they are enclosed in quotes. https://issues.redhat.com/browse/COCKPIT-1219 https://issues.redhat.com/browse/RHEL-72582
martinpitt
force-pushed
the
login-brand
branch
from
a460da5 to
1006150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't cut off the last character from brand names if they are enclosed
in quotes.
https://issues.redhat.com/browse/COCKPIT-1219
https://issues.redhat.com/browse/RHEL-72582
What an embarrassing bug... 🙈