lib: Some TypeaheadSelect and MultiTypeaheadSelect improvements #21482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For c-podman. |
In the TypeaheadSelect component, the focusedItemIndex is for the filteredSelections array, not for the selectOptions one. Thus without this fix, we would get the aria stuff wrong. We might even end up accessing non-existing items, when focusedItemIndex refers to a "No results found" fake entry in filteredSelections with index 0 while selectOptions is empty. The fake entries are now properly disabled and will be skipped by key navigation in both TypeaheadSelect and MultiTypeaheadSelect. Also, key navigation relies on there being at least one option that will not be skipped. Thus, we need to us isEnabledMenu instead of isMenu when deciding whether to return early. This got broken in 8d9f97b.
mvollmer
force-pushed
the
lib-typeahead-improvs
branch
from
de155fc to
09d94a2
Compare
cockpituous
reviewed
Jan 3, 2025
| @@ -535,6 +543,7 @@ export const TypeaheadSelectBase: React.FunctionComponent<TypeaheadSelectProps> | |||
| ); | |||
| })} | |||
| </SelectList> | |||
| { footer && <MenuFooter>{footer}</MenuFooter> } | |||
There was a problem hiding this comment.
This added line is not executed by any test.
1 task
martinpitt
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.