Sort beipack input file list #21460
Closed
Sort beipack input file list #21460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that cockpit-bridge.beipack.xz builds in a reproducible way in spite of non-deterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. This patch was done while working on reproducible builds for openSUSE.
|
Did you actually observe some non-reproducibility with that? Do you have a pointer? We are well aware of this, Debian also tests this (and it failed a long time ago), and then we fixed it with commit 43cfb22. In other words, the build system already sorts the result of |
|
I was testing with https://build.opensuse.org/package/show/openSUSE:Factory/cockpit that has cockpit-322 without commit 43cfb22. Adding it there, indeed fixes the issue. => closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort input file list, so that
cockpit-bridge.beipack.xzbuilds in a reproducible way in spite of non-deterministic filesystem readdir order.See https://reproducible-builds.org/ for why this is good.
This patch was done while working on reproducible builds for openSUSE.