cockpit: send now along with the internalmetrics meta
#21421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for figuring this out! 💯 Unconflict, please? |
jelly
force-pushed
the
fix-network-storage-metrics
branch
from
aabf9f6 to
9154123
Compare
The metrics for the networking and storage pages didn't show anything since we switched to the Python implementation. There was no integration test for internalmetrics so this regressed without us noticing as these graphs can also take data from PCP (archive or direct). Fixes: cockpit-project#19627
jelly
force-pushed
the
fix-network-storage-metrics
branch
from
9154123 to
6c1b233
Compare
martinpitt
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Thank you so much for figuring this out! This failure is obviously unrelated, and also rings a bell ("standard flake").
|
@martinpitt do you plan to backport this to RHEL 9 or should I open a case ? |
|
@champtar It'll go into 9.6 development series next Wednesday in any case. Of course if you need a ticket for tracking purposes, feel free to add one. |
This answer/ticket is enough, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics for the networking and storage pages didn't show anything since we switched to the Python implementation. There was no integration test for internalmetrics so this regressed without us noticing as these graphs can also take data from PCP (archive or direct).
Fixes: #19627