test: Add tests for MultiTypeaheadSelect #21417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
added
the
no-test
mvollmer
force-pushed
the
test-multi-typeahead-tests
branch
2 times, most recently
from
b1be1df to
30583d3
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
test-multi-typeahead-tests
branch
from
30583d3 to
d4982b8
Compare
|
@mvollmer This failure is relevant, the other two reds are flakes. |
|
This will conflict with #21356 as that also updates pixels. But that one is ready and more intrusive, so let's land that first. |
Grr. MultiTypeaheadSelect seems to have some bugs re I am running out of effs to give, would have been easier to write this all from scratch than to start with the templates. Let's just fix the test to avoid the problem. :-/ |
mvollmer
added
the
no-test
mvollmer
force-pushed
the
test-multi-typeahead-tests
branch
2 times, most recently
from
24f6bff to
914a128
Compare
|
Thanks! This looks nice, but is conflicty and no-test. |
mvollmer
force-pushed
the
test-multi-typeahead-tests
branch
from
914a128 to
6f19af4
Compare
mvollmer
removed
the
no-test
mvollmer
force-pushed
the
test-multi-typeahead-tests
branch
from
6f19af4 to
d0e0bf9
Compare
cockpituous
reviewed
Dec 17, 2024
Comment on lines
+159
to
+160
| if (!isOpen) { | ||
| openMenu(); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.