workflows: Build ws container from latest tag, not main #21331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we always built cockpit/ws with the latest main Dockerfile. But this broke the most recent cockpit/ws build (tag 329): It already removed cockpit session due to commit 035dc2d, but the rpms don't yet contain the prerequisite commit d7cb561 (that isn't in any release yet).
Let's not get ahead of ourselves and always build the container from the current release, not main.
See cockpit-project/bots#7141 where that broke badly. This can be trivially reproduced with
and going to http://localhost:9090 . This only affects privileged mode, unprivileged is fine.
I already reverted the ":latest" tag back to the previous build (327, sic!). I'll do a rebuild against this branch now and validate the result: https://github.com/cockpit-project/cockpit/actions/runs/12025898351