Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Build ws container from latest tag, not main #21331

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Nov 26, 2024

So far we always built cockpit/ws with the latest main Dockerfile. But this broke the most recent cockpit/ws build (tag 329): It already removed cockpit session due to commit 035dc2d, but the rpms don't yet contain the prerequisite commit d7cb561 (that isn't in any release yet).

Let's not get ahead of ourselves and always build the container from the current release, not main.


See cockpit-project/bots#7141 where that broke badly. This can be trivially reproduced with

sudo podman container runlabel RUN quay.io/cockpit/ws:329

and going to http://localhost:9090 . This only affects privileged mode, unprivileged is fine.

I already reverted the ":latest" tag back to the previous build (327, sic!). I'll do a rebuild against this branch now and validate the result: https://github.com/cockpit-project/cockpit/actions/runs/12025898351

So far we always built cockpit/ws with the latest main Dockerfile. But
this broke the most recent cockpit/ws build (tag 329): It already
removed cockpit session due to commit 035dc2d, but the rpms
don't yet contain the prerequisite commit d7cb561 (that isn't in
any release yet).

Let's not get ahead of ourselves and always build the container from the
current release, not main.
@martinpitt martinpitt added no-test For doc/workflow changes, or experiments which don't need a full CI run, .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows labels Nov 26, 2024
@martinpitt
Copy link
Member Author

martinpitt commented Nov 26, 2024

rebuilt, the log shows that it does not remove cockpit-session and checks out 329.1. Retested as per instructions above with quay.io/cockpit/ws:329.1 (I kept :latest at 327 as before).

@jelly jelly merged commit ca41bbe into main Nov 26, 2024
31 of 35 checks passed
@jelly jelly deleted the fix-ws-container-build branch November 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants