Remove unused css id #machine_id #19198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can checkout the screenshot of a component which uses the monospace at cockpit-project/cockpit-machines#1178 |
PF dropped pf-v5-global--FontFamily--redhat--monospace since patternfly/patternfly@4ec21e34fc3 The only place which was using it was #machine_id css id selector which is however not used anywhere, os let's just remove it.
|
I was trying to make pixel tests for this, but found out this is actually not the class which specifies the font of System ID on overview tab. In fact, this css class is not used anywhere. So let's just remove it |
skobyda
changed the title
jelly
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PF dropped pf-v5-global--FontFamily--redhat--monospace since patternfly/patternfly@4ec21e34fc3