test: Prevent bash TCO when keeping a mount point busy #17823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The alternative would be to expect TCO always and update the pixel |
|
This is needed for the fedora-36 refresh in cockpit-project/bots#3955 |
1 task
jelly
requested changes
Oct 18, 2022
Different versions of bash do tail call optimization in different scenarios, and the "Currently in use" pop-up would either show the bash process or not (depending on whether TCO was done). So let's prevent bash from doing TCO of the "sleep" call.
mvollmer
force-pushed
the
test-no-bash-tco
branch
from
0cfb46a to
82f294f
Compare
jelly
approved these changes
Oct 18, 2022
|
TestNetworkingCheckpoints.testNoRollback is fixed in #17829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different versions of bash do tail call optimization in different scenarios, and the "Currently in use" pop-up would either show the bash process or not (depending on whether TCO was done). So let's prevent bash from doing TCO of the "sleep" call.