Skip to content

Commit

Permalink
lib: Revert menu toggles to be transparent again
Browse files Browse the repository at this point in the history
This broke Anaconda.  Instead, only change them in "logs" and
"metrics".
  • Loading branch information
mvollmer authored and martinpitt committed Dec 16, 2024
1 parent bdf08e5 commit c32843a
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 9 deletions.
9 changes: 0 additions & 9 deletions pkg/lib/patternfly/patternfly-5-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -398,12 +398,3 @@ select.pf-v5-c-form-control {
background-color: var(--pf-v5-global--BackgroundColor--400);
}
}

/* Menu toggles are transparent in light mode (but not in dark
mode). This makes them white on a white page (fine), but grey in a
grey toolbar. The deprecated Select had a white background. Let's
make MenuToggles match.
*/
html:not(.pf-v5-theme-dark) .pf-v5-c-menu-toggle:not(.pf-m-primary) {
background-color: var(--pf-v5-global--BackgroundColor--100);
}
9 changes: 9 additions & 0 deletions pkg/metrics/metrics.scss
Original file line number Diff line number Diff line change
Expand Up @@ -852,3 +852,12 @@ $graphs: cpu, memory, disks, network;
}
}
}

/* Menu toggles are transparent in light mode (but not in dark
mode). This makes them white on a white page (fine), but grey in a
grey toolbar. The deprecated Select had a white background. Let's
make MenuToggles match.
*/
html:not(.pf-v5-theme-dark) .pf-v5-c-menu-toggle:not(.pf-m-primary) {
background-color: var(--pf-v5-global--BackgroundColor--100);
}
9 changes: 9 additions & 0 deletions pkg/systemd/logs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,12 @@
color: var(--pf-v5-global--Color--100);
}
}

/* Menu toggles are transparent in light mode (but not in dark
mode). This makes them white on a white page (fine), but grey in a
grey toolbar. The deprecated Select had a white background. Let's
make MenuToggles match.
*/
html:not(.pf-v5-theme-dark) .pf-v5-c-menu-toggle:not(.pf-m-primary) {
background-color: var(--pf-v5-global--BackgroundColor--100);
}

0 comments on commit c32843a

Please sign in to comment.