Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated font redhat--monospace with basic PF's monospace #1178

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Replace deprecated font redhat--monospace with basic PF's monospace #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/machines.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
}

.ct-monospace {
font-family: var(--pf-v5-global--FontFamily--redhat--monospace);
font-family: var(--pf-v5-global--FontFamily--monospace);
}

// Do not add a box-shadow to a "subsection", while it's technically correct it looks weird.
Expand Down
6 changes: 6 additions & 0 deletions test/check-machines-disks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ class TestMachinesDisks(VirtualMachinesCase):
pool_name=None, volume_name=None,
file_path=None,
force=False,
pixel_tag=None,
):
self.test_obj = test_obj
self.mode = mode
Expand All @@ -311,6 +312,7 @@ class TestMachinesDisks(VirtualMachinesCase):
self.volume_name = volume_name
self.target = target
self.force = force
self.pixel_tag = pixel_tag

def _get_disks(self):
m = self.test_obj.machine
Expand Down Expand Up @@ -403,6 +405,9 @@ class TestMachinesDisks(VirtualMachinesCase):
b.click(f"#vm-{self.vm_name}-disks-{self.target}-eject-button") # button
b.wait_in_text(".pf-v5-c-modal-box__title", "Eject disc from VM")

if self.pixel_tag:
b.assert_pixels(".pf-v5-c-modal-box", self.pixel_tag)

if self.mode == "custom-path":
b.wait_in_text(f"#vm-{self.vm_name}-disks-{self.target}-modal-description-file", self.file_path)
elif self.mode == "use-existing":
Expand Down Expand Up @@ -1632,6 +1637,7 @@ class TestMachinesDisks(VirtualMachinesCase):
mode='custom-path',
target='sda',
file_path='/var/lib/libvirt/novell.iso',
pixel_tag='vm-disc-eject-modal',
).execute()

self.VMInsertMediaDialog(
Expand Down
2 changes: 1 addition & 1 deletion test/reference
Open in desktop
Submodule reference updated 5 files
+ − TestMachinesDisks-testInsertDiscCDROM-vm-disc-eject-modal-dark-pixels.png
+ − TestMachinesDisks-testInsertDiscCDROM-vm-disc-eject-modal-medium-pixels.png
+ − TestMachinesDisks-testInsertDiscCDROM-vm-disc-eject-modal-mobile-pixels.png
+ − TestMachinesDisks-testInsertDiscCDROM-vm-disc-eject-modal-pixels.png
+ − TestMachinesDisks-testInsertDiscCDROM-vm-disc-eject-modal-rtl-pixels.png