Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add embla-carousel and embla-carousel plugins #313

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: add embla-carousel and embla-carousel plugins #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5244,6 +5244,21 @@
"emailjs": {
"version": "*"
},
"embla-carousel": {
"version": "*"
},
"embla-carousel-auto-height": {
"version": "*"
},
"embla-carousel-auto-scroll": {
"version": "*"
},
"embla-carousel-autoplay": {
"version": "*"
},
"embla-carousel-fade": {
"version": "*"
},
Comment on lines +5247 to +5261
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Verify completeness of embla-carousel ecosystem

The additions cover the core carousel functionality and common plugins. However, consider if other official plugins like embla-carousel-react or embla-carousel-vue should also be whitelisted to support different framework integrations.

Consider adding framework-specific bindings if they are commonly used:

+    "embla-carousel-react": {
+      "version": "^8.0.0"
+    },
+    "embla-carousel-vue": {
+      "version": "^8.0.0"
+    },

Committable suggestion was skipped due to low confidence.

⚠️ Potential issue

Consider pinning package versions instead of using wildcards

While adding the embla-carousel packages is valid, using wildcard versions ("*") for all packages could lead to unexpected breaking changes when new versions are released. Consider pinning to specific versions or using version ranges.

Apply this diff to use more specific version constraints:

-    "embla-carousel": {
-      "version": "*"
-    },
-    "embla-carousel-auto-height": {
-      "version": "*" 
-    },
-    "embla-carousel-auto-scroll": {
-      "version": "*"
-    },
-    "embla-carousel-autoplay": {
-      "version": "*"
-    },
-    "embla-carousel-fade": {
-      "version": "*"
-    },
+    "embla-carousel": {
+      "version": "^8.0.0"
+    },
+    "embla-carousel-auto-height": {
+      "version": "^8.0.0"
+    },
+    "embla-carousel-auto-scroll": {
+      "version": "^8.0.0"
+    },
+    "embla-carousel-autoplay": {
+      "version": "^8.0.0"
+    },
+    "embla-carousel-fade": {
+      "version": "^8.0.0"
+    },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"embla-carousel": {
"version": "*"
},
"embla-carousel-auto-height": {
"version": "*"
},
"embla-carousel-auto-scroll": {
"version": "*"
},
"embla-carousel-autoplay": {
"version": "*"
},
"embla-carousel-fade": {
"version": "*"
},
"embla-carousel": {
"version": "^8.0.0"
},
"embla-carousel-auto-height": {
"version": "^8.0.0"
},
"embla-carousel-auto-scroll": {
"version": "^8.0.0"
},
"embla-carousel-autoplay": {
"version": "^8.0.0"
},
"embla-carousel-fade": {
"version": "^8.0.0"
},

"emitter": {
"version": "*"
},
Expand Down
Loading