i added decorations to code #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with SDK 34 the following error occurs on devices that need older SDKs: ``` Failure [INSTALL_FAILED_OLDER_SDK: Requires newer sdk version cnlohr#34 (current version is cnlohr#33)] Performing Streamed Install adb: failed to install cnfgtest.apk: Failure [INSTALL_FAILED_OLDER_SDK: Requires newer sdk version cnlohr#34 (current version is cnlohr#33)] make: *** [Makefile:191: push] Error 1 ``` This is resolved by setting ANDROIDVERSION=29 in the AndroidManifest.xml target which sets android:minSdkVersion to the lowest SDK version supported by rawdrawandroid.
When building the x86 and / or x86_64 target(s) with SDK 34 and NDK 28.0.12674087, the following error occurs: ```error: unknown target CPU 'intel' note: valid target CPU values are: i386, i486, winchip-c6, winchip2, c3, i586, pentium, pentium-mmx, pentiumpro, i686, pentium2, pentium3, pentium3m, pentium-m, c3-2, yonah, pentium4, pentium4m, prescott, nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, rocketlake, icelake-server, tigerlake, sapphirerapids, alderlake, raptorlake, meteorlake, arrowlake, arrowlake-s, lunarlake, gracemont, pantherlake, sierraforest, grandridge, graniterapids, graniterapids-d, emeraldrapids, clearwaterforest, knl, knm, lakemont, k6, k6-2, k6-3, athlon, athlon-tbird, athlon-xp, athlon-mp, athlon-4, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, znver4, x86-64, geode make: *** [Makefile:138: makecapk/lib/x86/libcnfgtest.so] Error 1``` The fix is to omit -mtune flag or set -mtune=generic where generic is a better choice.
I should was first edit this, my mistake i saw your code and edited Charles's project
|
We should not hard code SDK versions in this location |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to ChatGPT:
Removed -mssse3, -msse4.2, and -mpopcnt:
Kept -m32 for 32-bit builds (CFLAGS_x86):
Kept -march for architecture specification:
Why -mtune=native Is Better in This Case
Using -mtune=native ensures that the generated code is tuned for the exact machine where it is compiled, potentially yielding better performance compared to the generic -mtune=intel. -------------
I DID NOT TEST THIS CODE!!!