-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sign Language Video Style Guide (SPA) to content/es/style-guide/index.md #3357
Conversation
Signed-off-by: Andrés García <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Based of #3313 Ping: @seokho-son |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tech-andgar muchas gracias por la actualización en el documento, parece ser que algunas palabras no están registradas en el diccionario local, podrías agregarlas en orden alfabético para que pueda pasar el CI?
Co-authored-by: Victor Morales <[email protected]> Signed-off-by: Andres Garcia <[email protected]>
@electrocucaracha |
@tech-andgar las palabras que agregaste están en el orden correcto, pero parece ser que tu editor de texto está cambiando, el fin del documento, por lo general eso sucede con editores windows o por alguna configuración en git ( Por otra parte, recuerda que cada commit debe ser firmado, en caso contrario no podra pasar el verificador de DCO |
Signed-off-by: Andrés García <[email protected]>
@electrocucaracha |
De mi parte |
Yo también estoy acostumbrado a escribir "video" sin acento. Sin embargo, investigando en la RAE, ambas son válidas: la opción sin acento mayormente usada en América Latina y con acento usada en España: https://www.rae.es/dpd/video Mi conclusión personal sería igual que @electrocucaracha, usar la opción sin acento (y agregarla al |
+1 sin acento video |
@tech-andgar puedes agregar la palabra |
Signed-off-by: Andrés García <[email protected]>
@electrocucaracha |
Signed-off-by: Andrés García <[email protected]>
Describe your changes
added the sign language video style guide (lang/es)
Related issue number or link (ex:
resolves #issue-number
)related to issue #3044 (comment)
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.