Merge pull request #241 from cnblogs/use-dnsendpoint

refactor: use DnsEndPoint
cnblogs · Nov 23, 2024 · 25cae83 · 25cae83
2 parents 5afe0c6 + 4fa29cf
commit 25cae83
Showing 1 changed file with 5 additions and 20 deletions.
diff --git a/src/Enyim.Caching/Configuration/MemcachedClientConfiguration.cs b/src/Enyim.Caching/Configuration/MemcachedClientConfiguration.cs
@@ -7,10 +7,8 @@
 using Microsoft.Extensions.Options;
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Net;
 using System.Net.Security;
-using System.Net.Sockets;
 
 namespace Enyim.Caching.Configuration
 {
@@ -208,7 +206,7 @@ public MemcachedClientConfiguration(
 
         private void ConfigureServers(MemcachedClientOptions options)
         {
-            Servers = new List<EndPoint>();
+            Servers = [];
             foreach (var server in options.Servers)
             {
                 if (options.UseSslStream)
@@ -217,29 +215,16 @@ private void ConfigureServers(MemcachedClientOptions options)
                 }
                 else
                 {
-                    if (!IPAddress.TryParse(server.Address, out var address))
+                    if (IPAddress.TryParse(server.Address, out var address))
                     {
-                        address = Dns.GetHostAddresses(server.Address)
-                            .FirstOrDefault(i =>
-                                i.AddressFamily == (options.UseIPv6
-                                    ? AddressFamily.InterNetworkV6
-                                    : AddressFamily.InterNetwork));
-
-                        if (address == null)
-                        {
-                            _logger.LogError($"Could not resolve host '{server.Address}'.");
-                        }
-                        else
-                        {
-                            _logger.LogInformation($"Memcached server address - {address}");
-                        }
+                        Servers.Add(new IPEndPoint(address, server.Port));
                     }
                     else
                     {
-                        _logger.LogInformation($"Memcached server address - {server.Address}:{server.Port}");
+                        AddServer(server.Address, server.Port);
                     }
 
-                    Servers.Add(new IPEndPoint(address, server.Port));
+                    _logger.LogInformation("Memcached server address - {address}:{port}", server.Address, server.Port);
                 }
             }
         }