Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract Filter API. #28

Closed
bamos opened this issue Sep 30, 2014 · 3 comments
Closed

Abstract Filter API. #28

bamos opened this issue Sep 30, 2014 · 3 comments
Labels
High Priority

Comments

@bamos
Copy link
Contributor

bamos commented Sep 30, 2014

Map[Str,Byte[]]: Double or Map[Str,Byte[]]: Boolean
bamos pushed a commit that referenced this issue Nov 29, 2014
#28: Add process loop.
b37ccc7
@bamos
Copy link
Contributor Author

bamos commented Nov 29, 2014

Hi @bgilbert - take a look at the commit above.
Good suggestion, this interface is much cleaner than before.

@bamos bamos closed this as completed Nov 29, 2014
@bgilbert
Copy link

bgilbert commented Dec 1, 2014

Since Filter is supposed to be generic, and only the caller will know what filters are actually available, FilterEnum and Filter.loadFilters() are problematic. It would be better to have the Filter constructor take a resource ID, and unpack the specified filter (and only that filter) itself.

Also, unpacking will need some work, because it shouldn't be done from the UI thread as it is now.

@bgilbert bgilbert reopened this Dec 1, 2014
@bamos bamos mentioned this issue Dec 1, 2014
Open
@bamos
Copy link
Contributor Author

bamos commented Dec 1, 2014

Moved to #29

@bamos bamos closed this as completed Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgilbert @bamos