Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass code as byte[] to Filter rather than an Enum pointing to the resource ID. #29

Open
bamos opened this issue Sep 30, 2014 · 2 comments

Comments

@bamos
Copy link
Contributor

bamos commented Sep 30, 2014

No description provided.

@bamos
Copy link
Contributor Author

bamos commented Dec 1, 2014

From @bgilbert in #28:

Since Filter is supposed to be generic, and only the caller will know what filters are actually available, FilterEnum and Filter.loadFilters() are problematic. It would be better to have the Filter constructor take a resource ID, and unpack the specified filter (and only that filter) itself.

Also, unpacking will need some work, because it shouldn't be done from the UI thread as it isnow.

@bamos
Copy link
Contributor Author

bamos commented Jan 2, 2015

I originally had the Enum wrapping res objects so the library could include
a default set of resources. The Enum was necessary because
applications using the library couldn't access the library's resources
directly.

I've removed the enum and the library's Filter class now loads the
resource ID from the application's resources.
I'm leaving this issue open for a binary constructor for Filter to be
added in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant