Add property-based testing #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielLiamAnderson Any thoughts on this PR? I'll keep working on polishing the code/documentation if you think this patch can potentially be merged. |
|
I'm not familiar with the RapidCheck library but this seems useful for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomized testing seems to be planned in #63 but was never actually done. This is an attempt at it using the rapidcheck library.
3 crashes have been found so far. They are documented by
FIXMEs. They all happen when malformed inputs are supplied to the library. For example,find_endsegfaults if the first list is shorter than the second list due to a bad index access, though it is supposed to returnlist1.end().Most functions tested by
test_primitives.cpphave been covered. More tests (and some documentation on running these tests) are forthcoming.