Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delphidocs on dev #567

Merged
merged 5 commits into from
Nov 14, 2024
Merged

delphidocs on dev #567

merged 5 commits into from
Nov 14, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.

Change explanations for reviewer

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. Let's see if GitHub Actions agrees...

@brookslogan brookslogan merged commit 17d22d9 into dev Nov 14, 2024
3 checks passed
@brookslogan
Copy link
Contributor

brookslogan commented Nov 14, 2024

Changes probably won't be immediate for the main (non-dev) site. Might need to manually use workflow dispatch to re-build main site if we don't release soon. [Nevermind, we would need to update some of the files as well. 566 is set to do this directly on main.]

@brookslogan
Copy link
Contributor

Hmm, dev site required a force-refresh on firefox to render correctly, but seems to look good now.

@brookslogan brookslogan deleted the delphidocs-dev branch November 14, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants