fix: improve reading of EPIDATR_USE_CACHE variable
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
requested review from
brookslogan,
dsweber2 and
nmdefries
as code owners
dshemetov
changed the title
EPIDATR_USE_CACHE variable
dsweber2
reviewed
Mar 7, 2024
nmdefries
approved these changes
Mar 8, 2024
|
|
||
| - Improve handling of the `EPIDATR_USE_CACHE` environment variable, allowing it | ||
| to be any value convertable by `as.logical()` and handle the case when it | ||
| can't be converted. |
There was a problem hiding this comment.
nit: please include PR number here
Suggested change
| can't be converted. | |
| can't be converted (#273). |
There was a problem hiding this comment.
ah my bad, I set it up to auto-merge, let's add this in a next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, dshemetov, nmdefries, dsweber2.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
Change explanations for reviewer
EPIDATR_USE_CACHEonly supported exactly "TRUE" before. Now it supports all logical values and includes a warning when any value that can't be converted to logical is provided.Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch