Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix web shell OOM issue #775

Merged
merged 3 commits into from
Nov 17, 2024
Merged

fix: fix web shell OOM issue #775

merged 3 commits into from
Nov 17, 2024
+10 −4

Conversation

xx01cyx
Copy link
Member

@xx01cyx xx01cyx commented Nov 17, 2024

Fix #774

connortsui20
connortsui20 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@connortsui20 connortsui20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xx01cyx xx01cyx merged commit 9f8bddd into master Nov 17, 2024
4 checks passed
@unw9527 unw9527 deleted the web-shell-memory-fix branch November 21, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connortsui20 connortsui20 connortsui20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bustub Shell crashing when queried for large tables or performing external merge sort
2 participants
@xx01cyx @connortsui20