Add CH-BenCHmark dialect-sqlserver.xml #517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mush-zhang
changed the title
|
LGTM, can you add a @bpkroth as reviewer? |
|
This looks reasonable to me. Unfortunately we don't run CH-BenCHmark in our tests. |
|
LGTM, but as @apavlo mentioned, can you please add it to CI tests here so we make sure this gets tested: I'm adding it to the rest of them in #519 |
1 task
bpkroth
added a commit
that referenced
this pull request
May 31, 2024
|
Hi @mush-zhang, I merged #519 to enable chbenchmark for most other backends. Can you please update your branch and enable tests following that pattern and let's make sure it passes CI so we can merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Sql Server Dialect for CH-benCHmark.