Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry CloseAuctions procedure in AuctionMark on rollback #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Retry CloseAuctions procedure in AuctionMark on rollback #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/main/java/com/oltpbenchmark/benchmarks/auctionmark/AuctionMarkWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,24 @@ protected boolean executeCloseAuctions(Connection conn, CloseAuctions proc) thro
Timestamp startTime = profile.getLastCloseAuctionsTime();
Timestamp endTime = profile.updateAndGetLastCloseAuctionsTime();

List<Object[]> results = proc.run(conn, benchmarkTimes, startTime, endTime);

List<Object[]> results = null;
boolean done = false;
// Retry here the close auction procedure if it fails due to a transactional conflict, since
// the original submitted procedured has a different type.
while (!done) {
try {
results = proc.run(conn, benchmarkTimes, startTime, endTime);
done = true;
}
Comment on lines +454 to +458
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't think we want to do this because we can't keep track of the # of times that a txn is submitted. So this can cause BenchBase to exceed the defined submission rate. Also, by retrying inside of the benchmark worker we can't keep track of the # failed txns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree that this is not the best approach. I also thought about adding an update method to the "TransactionType" class, so we can update the original "txnType" when we switch it in the "executeWork" function, making the worker deal with retries. This also would mean that the CloseAuctions procedure would be correctly logged in the results, since right now, as far as the worker knows, no CloseAuctions procedure is executed.

catch (SQLException e) {
if (e.getSQLState().startsWith("40")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "40"? Is this DBMS specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL states starting with 40 are related to transactional conflicts, such as "serialization failure" and "integrity constraint violation". As far as I know, it is standard across SQL systems.

conn.rollback();
}
Comment on lines +454 to +462
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this get stuck in an infinite loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, because sooner or later the transaction will be able to complete. Any other type of error other than transactional conflicts will raise an exception to the worker.

else {
throw e;
}
}
}

for (Object[] row : results) {
ItemId itemId = this.processItemRecord(row);
Expand Down