This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
fix: modify s3 read_all #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 21 21
Lines 3412 3412
Branches 3412 3412
=======================================
Hits 2960 2960
Misses 257 257
Partials 195 195 ☔ View full report in Codecov by Sentry. |
xx01cyx
reviewed
Apr 30, 2024
| async fn read_all(&self) -> ParpulseResult<Bytes> { | ||
| let mut bytes = BytesMut::new(); | ||
| async fn read_all(&self) -> ParpulseResult<Vec<Bytes>> { | ||
| let mut bytes_vec = Vec::new(); |
There was a problem hiding this comment.
Suggested change
| let mut bytes_vec = Vec::new(); | |
| let mut bytes_vec = Vec::with_capacity(self.keys.len()); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.