Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

chore: add trace generator and replace catalog with hashmap #45

Merged
merged 21 commits into from
Apr 28, 2024
Merged

Conversation

unw9527
Copy link
Member

@unw9527 unw9527 commented Apr 25, 2024

  1. Add a driver to benchmark transmission time for a 100MB parquet file from S3 to an EC2 instance.
  2. Add a test to check the response status when the file is not found on the server's disk.
  3. Add a trace generation script.
  4. Use a map to mimic the catalog.
  5. Decouple tests and batch size of the record batch.

@unw9527 unw9527 marked this pull request as draft April 25, 2024 03:57
@unw9527 unw9527 marked this pull request as ready for review April 25, 2024 04:20
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 58.77863% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 87.57%. Comparing base (844721e) to head (b7ba4ef).

Files Patch % Lines
storage-client/src/bin/driver.rs 0.00% 41 Missing ⚠️
storage-client/src/client.rs 77.77% 8 Missing ⚠️
storage-node/src/server.rs 92.45% 0 Missing and 4 partials ⚠️
storage-node/src/bin/storage_node.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   88.80%   87.57%   -1.23%     
==========================================
  Files          17       18       +1     
  Lines        2170     2262      +92     
  Branches     2170     2262      +92     
==========================================
+ Hits         1927     1981      +54     
- Misses        130      170      +40     
+ Partials      113      111       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unw9527 unw9527 marked this pull request as draft April 26, 2024 00:04
@unw9527 unw9527 marked this pull request as ready for review April 26, 2024 00:24
Copy link
Member

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

Copy link
Collaborator

@lanlou1554 lanlou1554 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unw9527 unw9527 merged commit 312a358 into main Apr 28, 2024
1 check passed
@unw9527 unw9527 deleted the lkl/traces branch April 28, 2024 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants