Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Coffea2023 #14

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
af6cde6
First updates for coffea2023
kmohrman Dec 19, 2023
37c42eb
More coffea 2023
kmohrman Dec 19, 2023
ca7de05
Do not need columns thing here
kmohrman Jan 3, 2024
747630d
Pass dict of samples to processor
kmohrman Jan 3, 2024
ce8d019
Do not loop over datasets in processor
kmohrman Jan 3, 2024
de47ff1
We pass the info for each json one at a time again
kmohrman Jan 3, 2024
e20d047
Update ele id xgb for coffea 2023
kmohrman Jan 4, 2024
a0e0937
Update mu xgb stuff too
kmohrman Jan 4, 2024
4b643d2
Reorganize xgb to factor out common part
kmohrman Jan 4, 2024
f1875f7
Uncomment lep ID and SFs
kmohrman Jan 4, 2024
40c5087
Make flake8 happy
kmohrman Jan 4, 2024
70d45f2
Need dask in conda env?
kmohrman Jan 4, 2024
3b894de
Dont need dak in processor
kmohrman Jan 4, 2024
f1fedb8
Ahh dont pin coffea version
kmohrman Jan 4, 2024
2573205
For now need coffea2023 branch of topcoffea
kmohrman Jan 4, 2024
9a7f7d3
Clean up
kmohrman Jan 4, 2024
2cfacfb
Enable sr bdt evaluation
kmohrman Jan 4, 2024
6d28fd1
Dont need xgb import
kmohrman Jan 4, 2024
5f6bdb2
Dont need np here
kmohrman Jan 4, 2024
f94e217
clean up run script
kmohrman Jan 4, 2024
e752129
In progress updates for scaling up
kmohrman Jan 4, 2024
d056850
Updates for distributed client
kmohrman Jan 5, 2024
0952ffc
Clean up run script a bit
kmohrman Jan 5, 2024
d8765cd
Tmp add run script and json for reproducing error
kmohrman Jan 7, 2024
192056a
Tmp make distributed client default in run script
kmohrman Jan 7, 2024
75ccf8b
Updates to run script
kmohrman Jan 8, 2024
4b70f10
Workaround from Lindsey to avoid overtouching
kmohrman Jan 11, 2024
b5411a0
No longer need workaround for None arrays, see ak issue 2768
kmohrman Jan 11, 2024
362a472
UAF 10 not working so switch to 8
kmohrman Jan 11, 2024
3be1cd9
Temp un-fix overtouching workaround
kmohrman Jan 11, 2024
a4a1856
Use events.nom for data for now, as weights object seems now to be No…
kmohrman Jan 12, 2024
1086d26
Remove this root file, it seems to be empty and causes error: files' …
kmohrman Jan 12, 2024
bdb9bd5
Add fsspec-xrootd to env file
kmohrman Jan 12, 2024
27da35d
Do not need to skip empty file anymore
kmohrman Jan 26, 2024
f8b185f
Merge remote-tracking branch 'origin/main' into coffea2023_systs
kmohrman Jan 28, 2024
b54550d
Deepcopy causes crash, probably dont even need copy.copy here
kmohrman Jan 28, 2024
25db1e1
Merge pull request #18 from cmstas/coffea2023_systs
kmohrman Jan 29, 2024
bcbfcdb
Fix weights for data
kmohrman Jan 30, 2024
26a0bb7
Try out parallelize_with_dask, temporary add exit after build task graph
kmohrman Feb 6, 2024
acbfc57
Clean up run script
kmohrman Mar 16, 2024
fc03300
Remove some old WQ stuff
kmohrman Mar 16, 2024
8920081
Using cache for masks
kmohrman Mar 17, 2024
43ae6b0
Remove unused import to make flake8 happy
kmohrman Mar 17, 2024
6d541cc
Adding jsons for hpg sample
kmohrman Mar 26, 2024
7f4cac4
Adding option to run with TaskVine
kmohrman Mar 26, 2024
0ed3830
Fix CI
kmohrman Mar 26, 2024
817f592
Fix some missing and duplicates, and add cfgs for the local jsons
kmohrman Apr 5, 2024
d3853cb
Update chunk size and just comment out the weird edge case problem fi…
kmohrman Jun 21, 2024
f91672e
Update README.md
kmohrman Jun 21, 2024
63abb06
Comment out samples for consistency, add run script
kmohrman Jun 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ewkcoffea/modules/selection_wwz.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def add4lmask_wwz(events, year, isData, sample_name):
def get_z_candidate_mask(lep_collection):

# Attach the local index to the lepton objects
lep_collection['idx'] = ak.local_index(lep_collection, axis=1)
lep_local_idx = ak.local_index(lep_collection, axis=1)

# Make all pairs of leptons
ll_pairs = ak.combinations(lep_collection, 2, fields=["l0","l1"])
Expand All @@ -251,8 +251,8 @@ def get_z_candidate_mask(lep_collection):
sfos_pair_closest_to_z_idx = ak.argmin(dist_from_z_sfos_pairs,axis=-1,keepdims=True)

# Construct a mask (of the shape of the original lep array) corresponding to the leps that are part of the Z candidate
mask = (lep_collection.idx == ak.flatten(ll_pairs_idx.l0[sfos_pair_closest_to_z_idx]))
mask = (mask | (lep_collection.idx == ak.flatten(ll_pairs_idx.l1[sfos_pair_closest_to_z_idx])))
flat_pair_idxs = ak.flatten(ll_pairs_idx[sfos_pair_closest_to_z_idx])
mask = ((lep_local_idx == flat_pair_idxs.l0) | (lep_local_idx == flat_pair_idxs.l1))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you ... unfix... this for now - some other people are looking that the over touching issue in your code in-situ :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfixed : )

mask = ak.fill_none(mask, False)

return mask
Expand Down
Loading