This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Feature/zero suppression wrap #43
Open
rodwyer100
wants to merge
23
commits into
cms-gem-daq-project:develop
Choose a base branch
from
rodwyer100:feature/zero-suppression-wrap
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/zero suppression wrap #43
rodwyer100
wants to merge
23
commits into
cms-gem-daq-project:develop
from
rodwyer100:feature/zero-suppression-wrap
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes allow for the vfat payloads to be read in differently based on what mode of zero suppression is given. It is structurally different from the original payload decoder because since the words no longer come in 64 bit chunks, and are quite variable, it reads in directly from the stream to populate objects. Only the vfat payloads have been modified in said manner, all other AMC, etc. objects are read off preciesly the same. The include file has been changed to include to sender methods required for this new manner of reading in from the stream.
Types of changes
Motivation and Context
This is motivated by our desire to require less space to send data, because alot of the events dont see any interesting interactions. Furthermore for calibration mode, the ultimately destructive mode included in this feature, it is the only means by which the tests can be done which require extremely high event numbers on a single channel. The main issue to stopping immediately implenetation is the creation of firmware designed to cooperate with it.
How Has This Been Tested?
Requires firmware to be tested completely. If zero suppression is disallowed, we can immediately test if (as I expect it is) it is backwards compatible with no suppression.
Screenshots (if appropriate):
Checklist:
TuesdayVFAT2.pptx
TuesdayVFAT.pptx