Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Feature/zero suppression wrap #43

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

rodwyer100
Copy link

@rodwyer100 rodwyer100 commented Aug 14, 2019

Description

The changes allow for the vfat payloads to be read in differently based on what mode of zero suppression is given. It is structurally different from the original payload decoder because since the words no longer come in 64 bit chunks, and are quite variable, it reads in directly from the stream to populate objects. Only the vfat payloads have been modified in said manner, all other AMC, etc. objects are read off preciesly the same. The include file has been changed to include to sender methods required for this new manner of reading in from the stream.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

This is motivated by our desire to require less space to send data, because alot of the events dont see any interesting interactions. Furthermore for calibration mode, the ultimately destructive mode included in this feature, it is the only means by which the tests can be done which require extremely high event numbers on a single channel. The main issue to stopping immediately implenetation is the creation of firmware designed to cooperate with it.

How Has This Been Tested?

Requires firmware to be tested completely. If zero suppression is disallowed, we can immediately test if (as I expect it is) it is backwards compatible with no suppression.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    TuesdayVFAT2.pptx
    TuesdayVFAT.pptx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant