ULV0 #1
ULV0 #1
Conversation
python/EgammaPostRecoTools.py
Outdated
| return "EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2017_24Feb2020_runEtaR9Gain_v2" | ||
|
|
||
| if era=="2016-UL" or era=="2018-UL": | ||
| raise RuntimeError('Error in postRecoEgammaTools, eras 2016-UL and 2018-UL are not yet have energy corrections, please contact the e/gamma pog for more information') |
There was a problem hiding this comment.
super minor but theres a typo here "do not" rather than "are not"
|
Excellent. It probably shouldnt be merged until the recipe is in place for the changes in EgammaTools and we have updated the twiki. But otherwise looks perfect. |
|
Hi @Sam-Harper In my previous version, I had not checked the compatibility with 11X. It seems there were some changes to MVAValueMapProducer: cms-sw/cmssw#26814 (comment) The corresponding PR (which I havent created yet) to the Reco/EgammaTools can be found here (in particular the changes done to determine the file format) - runMatrix ran fine on the changes: Thanks |
This is essentially taking care of putting in scales and smearing corrections for UL2017. As @Sam-Harper suggested, I now have removed any switch that takes an input of the file type for the reader of txt files.