Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug check_inf_parameters #974

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Fix a bug check_inf_parameters #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da6b919
fix check_inf_parameters which is atm bugged for counting experiments
Jun 17, 2024
db777c6
fixing paths
Jun 17, 2024
03067d8
really fixing paths
Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/cvmfs-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ jobs:
text2workspace.py HiggsAnalysis/CombinedLimit/data/tutorials/CAT23001/datacard-5-multi-signal.txt -P HiggsAnalysis.CombinedLimit.PhysicsModel:floatingXSHiggs --PO modes=ggH,qqH -o datacard-5-multi-signal.root --mass 125
combine datacard-5-multi-signal.root -M MultiDimFit --algo singles --mass 125
combine HiggsAnalysis/CombinedLimit/data/tutorials/CAT23001/datacard-5-multi-signal.txt -M ChannelCompatibilityCheck --mass 125
text2workspace.py HiggsAnalysis/CombinedLimit/data/tutorials/multiDim/toy-hgg-125.txt -m 125 -P HiggsAnalysis.CombinedLimit.PhysicsModel:floatingXSHiggs --PO modes=ggH,qqH
combine -M MultiDimFit HiggsAnalysis/CombinedLimit/data/tutorials/multiDim/toy-hgg-125.root




11 changes: 9 additions & 2 deletions src/utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,11 +892,18 @@ void utils::check_inf_parameters(const RooArgSet & params, int verbosity) {
for (RooAbsArg *arg : params) {
RooRealVar *p = dynamic_cast<RooRealVar *>(arg);
if (p->getRange().first <= -infinity_root626 || p->getRange().second >= +infinity_root626){

if ( verbosity > 2 ) {
std::cout << "Found a parameter named "<< p->GetName()
<< " infinite in ROOT versions < 6.30, going to removeRange()" << endl;
<< " infinite in ROOT versions < 6.30, going to update the ranges to take into account the new definition of infinity in ROOT v6.30" << endl;
}
if (p->getRange().first <= -infinity_root626 && p->getRange().second >= +infinity_root626) {
p->removeRange();
} else if (p->getRange().second >= +infinity_root626) {
p->removeMax();
} else {
p->removeMin();
}
p->removeRange();
}
}
}
Expand Down
Loading