[14x-comb2023] Avoid invalid proxy constructor calls in HMuMuRooPdfs #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `HMuMuRooPdfs`, there was a classic dangerous RooFit mistake.
There were constructor calls like:
```c++
RooRealProxy m("m", "m", this, 91.2);
```
However, this is not doing what one would naively expect, which is
having proxy to a constant. Instead, it will hit this constructor by
converting the `double` to `bool`, which is used as the `valueServer`
parameter:
https://root.cern/doc/v626/classRooTemplateProxy.html#a9a550633b5336561b48eb313994a68e8
So it will create a proxy to nothing! In this particular case, this was
not a problem because in `evaluate()`, there is a fallback for empty
proxies.
But ROOT 6.30 makes some compile-time checks to prevent these mistakes,
so this commit is necessary to compile with newer ROOT versions.
See https://root.cern/doc/v626/classRooTemplateProxy.html.
guitargeek
force-pushed
the
HMuMuRooPdf_fixes
branch
from
8b83ea6 to
089c8f1
Compare
guitargeek
changed the title
guitargeek
changed the title
jonathon-langford
merged commit 01df9a6
into
cms-analysis:14x-comb2023
1 of 5 checks passed
anigamova
pushed a commit
that referenced
this pull request
Jun 6, 2024
In the `HMuMuRooPdfs`, there was a classic dangerous RooFit mistake.
There were constructor calls like:
```c++
RooRealProxy m("m", "m", this, 91.2);
```
However, this is not doing what one would naively expect, which is
having proxy to a constant. Instead, it will hit this constructor by
converting the `double` to `bool`, which is used as the `valueServer`
parameter:
https://root.cern/doc/v626/classRooTemplateProxy.html#a9a550633b5336561b48eb313994a68e8
So it will create a proxy to nothing! In this particular case, this was
not a problem because in `evaluate()`, there is a fallback for empty
proxies.
But ROOT 6.30 makes some compile-time checks to prevent these mistakes,
so this commit is necessary to compile with newer ROOT versions.
See https://root.cern/doc/v626/classRooTemplateProxy.html.
anigamova
pushed a commit
that referenced
this pull request
Jun 6, 2024
In the `HMuMuRooPdfs`, there was a classic dangerous RooFit mistake.
There were constructor calls like:
```c++
RooRealProxy m("m", "m", this, 91.2);
```
However, this is not doing what one would naively expect, which is
having proxy to a constant. Instead, it will hit this constructor by
converting the `double` to `bool`, which is used as the `valueServer`
parameter:
https://root.cern/doc/v626/classRooTemplateProxy.html#a9a550633b5336561b48eb313994a68e8
So it will create a proxy to nothing! In this particular case, this was
not a problem because in `evaluate()`, there is a fallback for empty
proxies.
But ROOT 6.30 makes some compile-time checks to prevent these mistakes,
so this commit is necessary to compile with newer ROOT versions.
See https://root.cern/doc/v626/classRooTemplateProxy.html.
kcormi
pushed a commit
to kcormi/HiggsAnalysis-CombinedLimit
that referenced
this pull request
Jun 24, 2024
In the `HMuMuRooPdfs`, there was a classic dangerous RooFit mistake.
There were constructor calls like:
```c++
RooRealProxy m("m", "m", this, 91.2);
```
However, this is not doing what one would naively expect, which is
having proxy to a constant. Instead, it will hit this constructor by
converting the `double` to `bool`, which is used as the `valueServer`
parameter:
https://root.cern/doc/v626/classRooTemplateProxy.html#a9a550633b5336561b48eb313994a68e8
So it will create a proxy to nothing! In this particular case, this was
not a problem because in `evaluate()`, there is a fallback for empty
proxies.
But ROOT 6.30 makes some compile-time checks to prevent these mistakes,
so this commit is necessary to compile with newer ROOT versions.
See https://root.cern/doc/v626/classRooTemplateProxy.html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
HMuMuRooPdfs, there was a classic dangerous RooFit mistake.There were constructor calls like:
However, this is not doing what one would naively expect, which is
having proxy to a constant. Instead, it will hit this constructor by
converting the
doubletobool, which is used as thevalueServerparameter:
https://root.cern/doc/v626/classRooTemplateProxy.html#a9a550633b5336561b48eb313994a68e8
So it will create a proxy to nothing! In this particular case, this was
not a problem because in
evaluate(), there is a fallback for emptyproxies.
But ROOT 6.30 makes some compile-time checks to prevent these mistakes,
so this commit is necessary to compile with newer ROOT versions.
See https://root.cern/doc/v626/classRooTemplateProxy.html.