[14x-comb2023] Support ROOT 6.30 and C++20 #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destructor and assignment operators are not allowed to include
template specializations in C++20.
They were not needed anyway, because the class itself is templated.
Also, generalize the assignment operators to take `TH1` and check for
the dimension at runtime. This is necessary to avoid other compiler
warnings, such as:
```
interface/FastTemplate.h:123:34: warning: ‘FastTemplate_t<T>& FastTemplate_t<T>::operator=(const TH1&) [with T = double]’ was hidden [-Woverloaded-virtual=]
123 | virtual FastTemplate_t & operator=(const TH1 &other) {
| ^~~~~~~~
interface/FastTemplate.h:284:24: note: by ‘FastHisto2D_t<double>::operator=’
284 | FastHisto2D_t& operator=(const TH2 &other) {
```
That is a very valid warning! `FastHisto2D_t` inherits from
`FastTemplate_t`, and it's not good if their assignment operators take
different types.
This will not work anymore in ROOT 6.30. The `double` value needs to be retrieved from the proxy first.
|
The CI failures are not related to this PR. |
jonathon-langford
merged commit f063bbf
into
cms-analysis:14x-comb2023
0 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact port of #873.
This helps do debug some things in the Higgs combination.