-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for updating docs theme #877
Conversation
many of the changes are already merged into the |
Hi Nick, I tried out this theme and the build, it looks good to me, I think its a nice a nice improvement over the current one. And all the various boxes/features etc seem to be working. The only small thing I noticed, is I think in the current PR it is using an old version of the logo? The one on the pages has the fairly saturated colours, where I thought we were switching to the less saturated version. NB: I didn't check to make sure the content is unchanged, I have only been checking for style so far. |
Hi @kcormi - thanks, yeah the logo is a little outdated, currently getting the latest and greatest one from Clemens to add in. |
df58366
to
9310e5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just rebased this PR on top of the main, to see the changes more clearly.
The only conflict was in the physicsmodel.md
, which is now consistent although I don't know if we prefer to use $\vec{\mu}$
instead of $\vec{\theta}$
since I think the first one is consistent with the paper. This could also be updated in another PR, where we might want to check the notation and make it as consistent as we can though.
@nucleosynthesis, please just check that nothing got missed or changed in an unintended way.
Looks good to me - I think probably going with the \mu in the physics model is better since we use that in the paper (and in the rest of the docs I already tried to go through and update to use the paper notation where I could) |
Thanks, I've updated it to use From my side the PR looks ready. |
I'd be happy to have this one merged, since others are making edits to the docs (from the CAT hackathon), we should probably get this one in so we don't have conflicts later? |
This PR modifies the theme to be more like those used in other CMSSW codes (eg the CAT doc pages). No need to merge until we're ready to make that change.