implement option in FitterAlgoBase to toggle between nll backends #1028
Conversation
|
thanks @pkausw! were you planning to use this flag in createNLL call in line https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/src/FitterAlgoBase.cc#L225, right? I guess then we could use it with forceRecreateNLL_ set to true then |
|
Hi @anigamova , sorry for the late reply and thanks for the review! I'm not sure if I understand your question properly. The nllbackend is set as a global flag in the This global name space is then used in RooSimultaneousOpt to switch between a pure RooFit-based backend or the standard combine backend. So the option is already propagated, and should also work with |
|
@pkausw yes, you are right, I forgot that we already merged this addition to |
| @@ -85,6 +86,8 @@ FitterAlgoBase::FitterAlgoBase(const char *title) : | |||
| ("autoBoundsPOIs", boost::program_options::value<std::string>(&autoBoundsPOIs_)->default_value(autoBoundsPOIs_), "Adjust bounds for these POIs if they end up close to the boundary. Can be a list of POIs, or \"*\" to get all") | |||
| ("autoMaxPOIs", boost::program_options::value<std::string>(&autoMaxPOIs_)->default_value(autoMaxPOIs_), "Adjust maxima for these POIs if they end up close to the boundary. Can be a list of POIs, or \"*\" to get all") | |||
| ("forceRecreateNLL", "Always recreate NLL when running on multiple toys rather than re-using nll with new dataset") | |||
| ("nllbackend", boost::program_options::value<std::string>(&nllBackend_)->default_value(nllBackend_), "DEBUG OPTION, DO NOT USE! Set backend to create NLL. Choices: combine (default behavior), cpu, legacy, codegen") | |||
There was a problem hiding this comment.
It's a minor nitpick, but maybe it should be called nllBackend to be consistent with the other options in camelCase?
|
Thanks for figuring out how the options are handled and adding an option for the NLL evaluation backend! To me, this looks all good 👍 |
This PR implements an option to forward the switch to toggle nll backends that @guitargeek implemented some time ago to the relevant peace of code. This should work for the MultiDimFit and the FitDiagnostics methods since they internally call the FitterAlgoBase. Other methods can follow as we move along.
This should make it easier to identify breaking points that custom combine classes introduce with pure RooFit code, and would be an important step for the implementation of automatic differentiation in combine.